Repository navigation
correctly set __package__ in a module in a zip file - #609
Closed
marcelotduarte wants to merge 1 commit into
Closed
marcelotduarte wants to merge 1 commit into
marcelotduarte wants to merge 1 commit into
Conversation
…package__ as None, then change it; the code was based on new zipimport for py38 and adapted to set __package__
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zipimport set
__package__as None, then change it; the code was based on new zipimport for Python 3.8 (python/cpython#6809) and adapted to set__package__A small sample:
Edit:
This PR has no dependency
ONLY the sample needs PR #608 and this PR to work.
Edit2: I use this PR with success, but in a test with a sample of pyside2 I have issues. I'll investigate it.