#3976 Use Optional#orElseThrow instead of Optional#get on Java 10+ - #4138
Open
AnkitaAdvitot wants to merge 1 commit into
Open
AnkitaAdvitot wants to merge 1 commit into
AnkitaAdvitot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3976
Follow-up on #674. In generated mapper code, use
Optional#orElseThrowinstead ofOptional#getwhen compiling on Java 10 or later, while preservingOptional#getwhen targeting Java 8 or Java 9.Changes
isSourceVersionAtLeast10()toVersionInformationandDefaultVersionInformation, with unit tests inDefaultVersionInformationTest.VersionInformationtoDefaultConversionContextandMappingResolverImpl..get()onOptionalto emit.orElseThrow()on Java 10+:BeanMappingMethod.ftl&BeanMappingMethod.java(parameter unwrapping and after-mapping parameter bindings)NestedPropertyMappingMethod.javaPropertyMapping.javaTypeToOptionalConversion.javaOptionalGetWrapper.java&OptionalGetWrapper.ftlOptionalInt,OptionalLong,OptionalDouble) remain unchanged usinggetAsInt(),getAsLong(),getAsDouble().orElseThrow().Testing
./mvnw test -Dtest="*Optional*Test,DefaultVersionInformationTest" -pl processor(247 tests passing)./mvnw checkstyle:check -pl processor(0 violations)./mvnw compile -pl documentation(asciidoctor HTML & PDF generation verified)