perf: A3 — length-tracked result assembly in encoderEngine

strcpy + strcat + strcat each re-scans the destination from the start to find the null terminator. Replace with explicit strlen on each source plus a single memcpy to copy result (including NUL). Output bytes are unchanged. time ./unittest (best of 3, user): baseline = 114.13s after A3 = 113.19s delta = 0.82% cumulative Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rijnb · May 28, 2026 · May 28, 2026 · May 28, 2026 · May 28, 2026 · May 28, 2026
commit 1b01b82b73f69161798885052de04bf6f31ba52c
diff --git a/mapcodelib/mapcoder.c b/mapcodelib/mapcoder.c
@@ -1542,8 +1542,12 @@ static void encoderEngine(const enum Territory ccode, const EncodeRec* enc, cons
                             }
                             else {
                                 getTerritoryIsoName(s, ccodeFinal, 0);
-                                strcat(s, " ");
-                                strcat(s, result);
+                                {
+                                    size_t isoLen = strlen(s);
+                                    size_t resultLen = strlen(result);
+                                    s[isoLen] = ' ';
+                                    memcpy(s + isoLen + 1, result, resultLen + 1);  /* +1 includes NUL */
+                                }
                             }
                         }
                         if (requiredEncoder == i) {