Skip to content

12% speed optimization #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rijnb wants to merge 15 commits into from
Closed

12% speed optimization #35

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
47e0d32
Fix critical and major code review issues
rijnb May 28, 2026
ea028ff
updagted version
rijnb May 28, 2026
740bfec
docs: design spec for mapcodelib speed optimization
rijnb May 28, 2026
9813f71
docs: implementation plan for mapcodelib speed optimization
rijnb May 28, 2026
f1cb736
chore: pin perf baseline for feat/optimize
rijnb May 28, 2026
430bbba
perf: A1 — cache flags per loop iteration in hot paths
rijnb May 28, 2026
b9b3f2c
perf: A2 — reorder fitsInsideBoundaries to test longitude first
rijnb May 28, 2026
5246c79
revert: A2 — reorder fitsInsideBoundaries (caused regression)
rijnb May 28, 2026
1b01b82
perf: A3 — length-tracked result assembly in encoderEngine
rijnb May 28, 2026
753c337
perf: A4 — single division per iteration in encodeBase31
rijnb May 28, 2026
554af29
perf: B1+B2+B3 — add precomputed companion tables and one-time init
rijnb May 28, 2026
3416f87
perf: B4 — hot loops read from precomputed companion tables
rijnb May 28, 2026
2cdf52b
perf: B5 — DEBUG-build sanity check for companion tables
rijnb May 28, 2026
9f99fa8
docs: record final perf results for feat/optimize branch
rijnb May 28, 2026
d5778ab
docs: add perf results table to docs/superpowers
rijnb May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert: A2 — reorder fitsInsideBoundaries (caused regression) 
Reverts b9b3f2c. isInRange() wraps longitude and has higher overhead
than simple comparisons; testing it first regressed user time by ~7.9s
vs A1 baseline. Reverting to lat-first ordering.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
  • Loading branch information
@rijnb @claude
rijnb and claude committed May 28, 2026
commit 5246c7928a5180d7d179f265fd1bd62e7c65ffaa
6 changes: 3 additions & 3 deletions mapcodelib/mapcoder.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,9 +602,9 @@ static int isInRange(int lonMicroDeg, const int minLonMicroDeg, const int maxLon
static int fitsInsideBoundaries(const Point32* coord32, const TerritoryBoundary* b) {
ASSERT(coord32);
ASSERT(b);
return (isInRange(coord32->lonMicroDeg, b->minx, b->maxx) &&
b->miny <= coord32->latMicroDeg &&
coord32->latMicroDeg < b->maxy);
return (b->miny <= coord32->latMicroDeg &&
coord32->latMicroDeg < b->maxy &&
isInRange(coord32->lonMicroDeg, b->minx, b->maxx));
}


Expand Down