You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Okay. But I'm thinking this is not a major problem overall. I think this is only an issue for how the node-pre-gyp tests work and I can adapt (working on this now). The critical lib/testbinary.js test I think is working for io.js because it actually uses process.execPath will brings in the right binary name.
(Starting from nodejs/node-gyp#564 (comment) some comments seem to imply that process.execPath might become less reliable in the future. However, that's merely a distant possibility.)
Activity
springmeyer commentedon Feb 17, 2015
disabled in 3124486 just to keep appveyor green for node.js until this mystery is solved.
Mithgol commentedon Feb 17, 2015
I am almost sure that's nodejs/node#751.
springmeyer commentedon Feb 17, 2015
@Mithgol - thank you - that certainly looks like the problem.
attemp to workaround nodejs/node#751 - refs #147
Mithgol commentedon Feb 17, 2015
On nodejs/node#751 they're going to fix this problem on the engine's level, but it can also be fixed on a build tools' level — nodejs/node-gyp#564.
(That's a good thing unless some bystander effect happens.)
springmeyer commentedon Feb 17, 2015
Okay. But I'm thinking this is not a major problem overall. I think this is only an issue for how the node-pre-gyp tests work and I can adapt (working on this now). The critical
lib/testbinary.jstest I think is working for io.js because it actually usesprocess.execPathwill brings in the right binary name.$ node -e "console.log(process.execPath)" /Users/dane/.nvm/versions/io.js/v1.2.0/bin/iojsSo, to recap: this should not prevent node-pre-gyp working for users of io.js at all. Right?
Mithgol commentedon Feb 17, 2015
Right.
(Starting from nodejs/node-gyp#564 (comment) some comments seem to imply that
process.execPathmight become less reliable in the future. However, that's merely a distant possibility.)springmeyer commentedon Feb 17, 2015
fixed in #148