Skip to content

io.js tests fail on windows #147

Closed
Closed

Description

@springmeyer

With io.js the node-pre-gyp tests that shell out to npm test for each test app fail on windows/appveyor with Module did not self-register.

https://ci.appveyor.com/project/Mapbox/node-pre-gyp/build/1.0.216/job/2psngm8nbqjl9w7g#L373

No idea yet what is going wrong.

Activity

  1. springmeyer commented on Feb 17, 2015

    @springmeyer
    ContributorAuthor

    disabled in 3124486 just to keep appveyor green for node.js until this mystery is solved.

  2. Mithgol commented on Feb 17, 2015

    @Mithgol
    Contributor

    I am almost sure that's nodejs/node#751.

  3. springmeyer commented on Feb 17, 2015

    @springmeyer
    ContributorAuthor

    @Mithgol - thank you - that certainly looks like the problem.

  4. added a commit that references this issue on Feb 17, 2015
  5. Mithgol commented on Feb 17, 2015

    @Mithgol
    Contributor

    On nodejs/node#751 they're going to fix this problem on the engine's level, but it can also be fixed on a build tools' level — nodejs/node-gyp#564.

    (That's a good thing unless some bystander effect happens.)

  6. springmeyer commented on Feb 17, 2015

    @springmeyer
    ContributorAuthor

    Okay. But I'm thinking this is not a major problem overall. I think this is only an issue for how the node-pre-gyp tests work and I can adapt (working on this now). The critical lib/testbinary.js test I think is working for io.js because it actually uses process.execPath will brings in the right binary name.

    $ node -e "console.log(process.execPath)"
    /Users/dane/.nvm/versions/io.js/v1.2.0/bin/iojs

    So, to recap: this should not prevent node-pre-gyp working for users of io.js at all. Right?

  7. Mithgol commented on Feb 17, 2015

    @Mithgol
    Contributor

    Right.

    (Starting from nodejs/node-gyp#564 (comment) some comments seem to imply that process.execPath might become less reliable in the future. However, that's merely a distant possibility.)

  8. springmeyer commented on Feb 17, 2015

    @springmeyer
    ContributorAuthor

    fixed in #148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions