Resolve namespace page roots as top-level pages - #13502
Open
tiensonqin wants to merge 3 commits into
Open
tiensonqin wants to merge 3 commits into
tiensonqin wants to merge 3 commits into
Conversation
First path segment of a namespaced page or tag now looks up only a top-level page or Root-extending tag, so Bar/Foo then Foo/Baz creates a Library Foo instead of nesting Baz under Bar/Foo. Co-authored-by: Tienson Qin <tiensonqin@gmail.com>
Reuse of an existing top-level tag no longer writes a nil extends. Tag create still rejects a property or top-level page as the first segment so mixed-parent validation stays fail-fast. Co-authored-by: Tienson Qin <tiensonqin@gmail.com>
devin-ai-integration
Bot
force-pushed
the
logseq/fix-namespace-root-lookup-17a6
branch
from
October 2, 2026 12:17
eb37bff to
da0eac2
Compare
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes logseq/db-test#1348
Creating
Foo/BazafterBar/Foono longer nests Baz under Bar's Foo. The first namespace segment now resolves only a top-level page (Library or parentless) or a Root-extending tag, then later segments look up children on that resolved parent.Same path is used for tags, so
#foo/barthen#Bar/Fookeeps two case-distinct trees.Tests
create-namespace-pages-root-is-order-independentcovers Bar/Foo then Foo/Baz, the reverse order, reuse of a standalone Foo, and Foo/Baz/Qux after Bar/Foo/Bazcreate-namespace-tags-root-is-case-and-order-independentcovers the tag case-variant sequence and reuse of a shared parent taglogseq.outliner.page-test: 19 tests, 113 assertionsdeps/outlinersuite: 137 tests, 701 assertionsLink to Devin session: https://app.devin.ai/sessions/3a4208ad1b644845abf6880feaf0be3d
Open in Devin Desktop: https://app.devin.ai/desktop/session/3a4208ad1b644845abf6880feaf0be3d?variant=devin
Requested by: @megayu