Repository navigation
[libc++] Remove workaround for clang-tidy 16 in the test suite setup code - #69035
Merged
Merged
Conversation
llvmbot
added
the
libc++
Member
|
@llvm/pr-subscribers-libcxx Author: Louis Dionne (ldionne) ChangesWe have moved to clang-tidy 17 now, so the workaround shouldn't be necessary. Full diff: https://github.com/llvm/llvm-project/pull/69035.diff 1 Files Affected:
diff --git a/libcxx/utils/libcxx/test/params.py b/libcxx/utils/libcxx/test/params.py
index 456794b9b1cce95..0c043cc6e55ccee 100644
--- a/libcxx/utils/libcxx/test/params.py
+++ b/libcxx/utils/libcxx/test/params.py
@@ -77,11 +77,6 @@
def getStdFlag(cfg, std):
- # TODO(LLVM-17) Remove this clang-tidy-16 work-around
- if std == "c++23":
- std = "c++2b"
- if hasCompileFlag(cfg, "-std=" + std):
- return "-std=" + std
# TODO(LLVM-19) Remove the fallbacks needed for Clang 16.
fallbacks = {
"c++23": "c++2b",
|
…code We have moved to clang-tidy 17 now, so the workaround shouldn't be necessary.
ldionne
force-pushed
the
review/getStdFlag
branch
from
October 14, 2023 00:17
736ee89 to
a61791f
Compare
philnik777
approved these changes
Oct 14, 2023
paleauraaaa
pushed a commit
to paleauraaaa/llvm-project
that referenced
this pull request
Oct 7, 2026
…code (llvm#69035) We have moved to clang-tidy 17 now, so the workaround shouldn't be necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have moved to clang-tidy 17 now, so the workaround shouldn't be necessary.