Skip to content

[libc++] Implement P2897R7 aligned_accessor: An mdspan accessor expressing pointer over-alignment #122603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dalg24 merged 22 commits into from
Apr 14, 2025
Merged

[libc++] Implement P2897R7 aligned_accessor: An mdspan accessor expressing pointer over-alignment #122603

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
2766103
[libc++] Implement P2897R7 aligned_accessor: An mdspan accessor expre…
dalg24 Jan 11, 2025
e36bc1c
Run the generate scripts
dalg24 Jan 12, 2025
1c57f20
Add missing header include for default_accessor
dalg24 Jan 13, 2025
68ea167
Missing header includes in tests
dalg24 Jan 13, 2025
1db762c
Fix access and offset tests
dalg24 Jan 13, 2025
625a421
Merge branch 'main' of https://github.com/llvm/llvm-project into alig…
dalg24 Jan 31, 2025
d2eccee
Add a release note
dalg24 Jan 31, 2025
64f14e7
Update release version 20 -> 21
dalg24 Jan 31, 2025
baefcf9
Fix header include <cstd{int -> def}> and qualify std::size_t
dalg24 Jan 31, 2025
47d3c56
Move verify tests to test/libcxx/
dalg24 Jan 31, 2025
eda7039
Drop superfluous constexpr, fix includes, and qualify std::size_t
dalg24 Jan 31, 2025
2cd1d28
Drop stray commented empty lines and superfluous constexpr
dalg24 Jan 31, 2025
8376d2f
Fix access and offset tests to work with constexpr
dalg24 Jan 31, 2025
a863a60
Correct oversight stray constexpr
dalg24 Feb 1, 2025
80e4a2d
Merge branch 'main' of https://github.com/llvm/llvm-project into alig…
dalg24 Mar 10, 2025
4abd141
Add coverage for which sizeof(T) is not equal to alignof(T)
dalg24 Mar 10, 2025
70f331a
Do not assume that sizeof(T) is the same as alignof(T) in test
dalg24 Mar 10, 2025
ac9792a
Merge branch 'main' into aligned_accessor
ldionne Mar 31, 2025
c3dfcda
Merge branch 'main' of https://github.com/llvm/llvm-project into alig…
dalg24 Apr 3, 2025
14c4606
Merge branch 'main' into aligned_accessor
dalg24 Apr 7, 2025
a55bef7
Merge branch 'main' into aligned_accessor
frederick-vs-ja Apr 9, 2025
9b5ef48
Merge branch 'main' of https://github.com/llvm/llvm-project into alig…
dalg24 Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Drop stray commented empty lines and superfluous constexpr
  • Loading branch information
@dalg24
dalg24 committed Jan 31, 2025
commit 2cd1d2815ff58131d4a3b899fec3cc8af91382a5
6 changes: 2 additions & 4 deletions libcxx/test/std/utilities/memory/ptr.align/is_sufficiently_aligned.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@

// template<size_t Alignment, class T>
// bool is_sufficiently_aligned(T* ptr);
//
//

#include <cassert>
#include <cstddef>
Expand All @@ -23,7 +21,7 @@
#include "test_macros.h"

template <typename T>
constexpr void test_is_sufficiently_aligned() {
void test_is_sufficiently_aligned() {
constexpr std::size_t N = alignof(T);

alignas(8 * N) std::remove_cv_t<T> buf[5];
Expand Down Expand Up @@ -55,7 +53,7 @@ constexpr void test_is_sufficiently_aligned() {
}

template <typename T>
constexpr void check(T* p) {
void check(T* p) {
ASSERT_SAME_TYPE(bool, decltype(std::is_sufficiently_aligned<alignof(T)>(p)));
test_is_sufficiently_aligned<T>();
test_is_sufficiently_aligned<const T>();
Expand Down