Conversation
CatarinaGamboa
left a comment
CatarinaGamboa
left a comment
Collaborator
There was a problem hiding this comment.
One small thing for #124's Node 22 move, outside this diff:
.devcontainer/devcontainer.json still uses mcr.microsoft.com/devcontainers/javascript-node:20. The point of the move is that the Vitest and @vscode/test-electron versions added later in this stack need Node 22, so anyone working in the devcontainer will hit that once #140 / #144 land, while CI on 22 passes. Suggest bumping the image to javascript-node:22, and optionally adding "engines": { "node": ">=22" } to client/package.json.
Reviewed with Claude Code (reviewer + adversarial agents per PR, findings checked against the code before posting).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #124.
Update ESLint, remove obsolete test scripts and unused tooling, and move publishing to Node 22. Fix existing semicolon violations.
Validated on Node 22: dependency install, lint, type checking, production build, and extension installation.
Generated by Codex.