hii: fail writes to questions without supported storage - #19
Open
dishendradeshmukh1986 wants to merge 1 commit into
Open
dishendradeshmukh1986 wants to merge 1 commit into
dishendradeshmukh1986 wants to merge 1 commit into
Conversation
Member
|
Could you resolve the merge conflict, please? :) |
Validation found that setting a matched question without a supported varstore returned success with an empty response and changed nothing. This could make callers mistake an unsupported operation for success. Return an explicit error naming the question when writable storage cannot be resolved. Preserve the normal write path for supported buffer and EFI varstores, and report success only after writing. Add tests for unresolved storage and OneOf questions. Keep existing question-not-found behaviour separate from this matched-question fix. Signed-off-by: Dishendra Deshmukh <dishendra.deshmukh@arm.com> Change-Id: I0861e2a8c7dca98c3b5edc965b494aaabc833286
dishendradeshmukh1986
force-pushed
the
fix/hii-missing-writable-storage
branch
from
October 2, 2026 19:46
03630ba to
9022aab
Compare
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
writable VarStore.
Problem
Setting a matched question without supported storage returned success with
an empty response and changed nothing. Callers could mistake the unsupported
operation for a successful update.
Validation
cargo test --locked --lib --binspassed:The combined write-safety series was also validated on an Arm64 UEFI
system using a real
TPM DeviceEFI variable: