Skip to content

doc: update supported linux/glibc baseline - #1324

Merged
bnoordhuis merged 1 commit into
libuv:v1.xfrom
bnoordhuis:update-supported-platforms
Apr 28, 2017
Merged

bnoordhuis merged 1 commit into
libuv:v1.xfrom
bnoordhuis:update-supported-platforms

Conversation

@bnoordhuis

Copy link
Copy Markdown
Member

Now that RHEL/CentOS 5 is end-of-life, update the baseline from
linux >= 2.6.18 + glibc >= 2.5 to linux >= 2.6.32 + glibc >= 2.12.

Refs: nodejs/node#12672

@saghul

saghul commented Apr 27, 2017

Copy link
Copy Markdown
Member

LGTM. Do we plan to remove any workarounds we have in place for older glibc versions? (IIRC there is some dlsym-ing around for some functions).

@bnoordhuis

Copy link
Copy Markdown
Member Author

I believe we only dlsym for android, which I didn't plan on touching. We could remove quite a bit of < 2.6.32 support code (code paths that work around missing system calls) but I'm undecided if we should do that at this time.

@cjihrig

cjihrig commented Apr 27, 2017

Copy link
Copy Markdown
Contributor

We could remove quite a bit of < 2.6.32 support code (code paths that work around missing system calls) but I'm undecided if we should do that at this time.

Maybe for v2?

@saghul

saghul commented Apr 28, 2017

Copy link
Copy Markdown
Member

Surely for V2 then! :-)

@bnoordhuis

Copy link
Copy Markdown
Member Author

Yes, it certainly make sense for v2. For v1.x, I'd say we keep it until it becomes a pain to maintain (which is subjective but that is what consensus is for.)

I'll go ahead and merge this.

Now that RHEL/CentOS 5 is end-of-life, update the baseline from
linux >= 2.6.18 + glibc >= 2.5 to linux >= 2.6.32 + glibc >= 2.12.

PR-URL: libuv#1324
Refs: nodejs/node#12672
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@bnoordhuis
bnoordhuis force-pushed the update-supported-platforms branch from 9d4292b to 4e61013 Compare April 28, 2017 09:22
@bnoordhuis bnoordhuis closed this Apr 28, 2017
@bnoordhuis
bnoordhuis deleted the update-supported-platforms branch April 28, 2017 09:22
@bnoordhuis
bnoordhuis merged commit 4e61013 into libuv:v1.x Apr 28, 2017
@saghul

saghul commented Apr 28, 2017

Copy link
Copy Markdown
Member

Agreed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants