android: use application context where appropriate - #16321
Open
Packetdancer wants to merge 1 commit into
Open
Packetdancer wants to merge 1 commit into
Packetdancer wants to merge 1 commit into
Conversation
We keep hitting weird lifecycle edge-cases where some Android variant will kill and garbage-collect the activity before we get a shutdown on controllers or audio. Since we are only using a context in those situations, rather than any of the activity-specific stuff, use the application context (which will stay valid for the lifetime of the process) rather than the activity context (which is not guaranteed to do so).
slouken
reviewed
Sep 14, 2026
Comment on lines
+85
to
+86
| } | ||
| else { |
Collaborator
There was a problem hiding this comment.
Suggested change
| } | |
| else { | |
| } else { |
slouken
reviewed
Sep 14, 2026
| return mContext; | ||
| } | ||
|
|
||
| static public Context getStaticContext() { |
Collaborator
There was a problem hiding this comment.
Suggested change
| static public Context getStaticContext() { | |
| static public Context getApplicationContext() { |
slouken
reviewed
Sep 14, 2026
| mApplicationContext = context.getApplicationContext(); | ||
| } | ||
| else { | ||
| mApplicationContext = null; |
Collaborator
There was a problem hiding this comment.
Do we really want to clear the application context here?
Collaborator
|
Extending this a little more, are there cases where we want the activity context instead of the application context, or do we always want the application context? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We keep hitting weird lifecycle edge-cases where some Android variant will kill and garbage-collect the activity before we get a shutdown on controllers or audio.
Since we are only using a context in those situations, rather than any of the activity-specific stuff, use the application context (which will stay valid for the lifetime of the process) rather than the activity context (which is not guaranteed to do so).
It's a fairly small and low-impact change that should globally benefit Android SDL apps.
Existing Issue(s)
I don't think we have an actual issue in the issue tracker for this, but slouken and I have both been on an email chain about one. :)