[Tiled] add list property type support - #7864
Open
Quillraven wants to merge 4 commits into
Open
Quillraven wants to merge 4 commits into
Quillraven wants to merge 4 commits into
Conversation
Contributor
Author
|
@MRZ07 @damnedpie @tommyettinger notify some people from previous Tiled PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Tiled's
listattributes. I used the existingTiledMapPropertiesTestand added a few more objects. I am not sure if I covered all cases because there are so many combinations now with classes/lists/nested classes/nested lists. Hope some of the Tiled guys like @BoBIsHere86 can have a look at it as well and try out some other cases that I have missed.The solution I went for is that we store list attributes as GDX Array instances. From what I have seen this is also how Tiled stores it and a Tiled array like [1, 2, "some", "text"] becomes the LibGDX Array counterpart.
A Tiled list like this:
becomes this GdxArray:
