make arr['key1;key2'] work #904

Activity

1. gdementen

   added

   enhancement

   on Dec 23, 2020
2. gdementen

   self-assigned this

   on Mar 1, 2021
3. gdementen

   added

   work in progress

   on Mar 1, 2021
4. gdementen

   added this to the 0.34 milestone on Aug 12, 2021
5. gdementen

   added a commit that references this issue on Oct 11, 2021

   FEAT: allow ; in __getitem__ and __setitem__ (closes larray-project#904)

   ...

   This issue will close once commit 6f60ef7 is merged into the 'master' branch.

   6f60ef7
6. gdementen

   added

   question

   syntax

   difficulty: high

   on Oct 21, 2022
7. gdementen commented on Oct 21, 2022

   

   gdementen

   on Oct 21, 2022

   Last edited by gdementen

   ContributorAuthor

   More actions

   Moving this issue and the corresponding PR to milestone 0.35 because it makes ';' ambiguous in the context of group aggregates. For example:

   arr.sum('a2;b1..b3') 

   currently means two groups on the same axis. We have two options here:

   • either use another separator between groups on the same axis. This would be cleanest but would break backward compatibility. For example, in the following there would be a b1,b2,b3,b5 group and another b7,b8,b9 group:

   arr.sum('a1,a3;b1..b3,b5/b7:b9') 

   • somehow (unsure it is possible to implement this easily/without introducing some ambiguous cases) allow several groups from the same axis and groups from different axes using the same separator. For example, make this work:

   arr.sum('a1,a3;b1..b3,b5;b7:b9') 

   In that case, we could require the groups to be enclosed by [ ] or ( ) and separate groups on the same axis by , (but that would be backward incompatible)

   arr.sum('a1,a3;[b1..b3],[b5:b7]') 

   Either way, this needs more thoughts.

   @alixdamman : if you have any idea on how to solve this, please speak 😉
8. gdementen

   modified the milestones: 0.34, 0.35 on Oct 21, 2022
9. gdementen commented on Feb 15, 2023

   

   gdementen

   on Feb 15, 2023

   Last edited by gdementen

   ContributorAuthor

   More actions

   In that case, we could require the groups to be enclosed by [ ] or ( ) and separate groups on the same axis by , (but that would be backward incompatible)

   arr.sum('a1,a3;[b1..b3],[b5:b7]') 

   Using [ and ] seems like a bad idea to me now because we cannot reproduce this outside the string syntax and it makes the [ kinda ambiguous.

   Using ( and ) around the different groups on the same axis would make more sense I think (this would match pretty closely with what we need to do with the non-string syntax):

   # match two groups -> group aggregate
   arr.sum('a1,a3;(b1..b3,b5;b7:b9)') 
   # a single group -> axis disappears
   arr.sum('a1,a3;b1..b3,b5,b7:b9') 

   In any cases (parentheses or not), we will need to decide if we want to support this:

   # match two groups on b -> group aggregate
   arr.sum('a1,a3;b1..b3,b5;b7:b9') 
10. gdementen

    modified the milestones: 0.35, 0.36 on Sep 11, 2023
11. gdementen

    modified the milestones: 0.36, 0.37 on Oct 6, 2025