Skip to content

array[slice_group_from_an_incompatible_axis] is buggy #1146

Open

Description

@gdementen

I am pretty sure there are cases where the group is retargeted to the correct axis, but at least in this case it isn't while it should:

>>> arr = ndtest(3)
>>> a2 = Axis('a=a0,a1')
>>> arr[a2]  # <-- correct
a  a0  a1
    0   1
>>> arr[a2[:]]  # <-- wrong
a  a0  a1  a2
    0   1   2

Activity

  1. added this to the 0.35 milestone on Dec 2, 2025
  2. gdementen commented on Dec 2, 2025

    @gdementen
    ContributorAuthor

    related to #1117 and #1138

  3. gdementen commented on Dec 4, 2025

    @gdementen
    ContributorAuthor

    I don't understand how I never stumbled on this bug, but this is not a recent regression like I thought. It dates back to at least 0.31, so I suppose it has always been there.

  4. added 2 commits that reference this issue on Dec 4, 2025
    12f444f
    1e1c892
  5. added a commit that references this issue on Dec 5, 2025
    5b2b66b
  6. modified the milestones: 0.35, 0.36 on Dec 18, 2025
  7. gdementen commented on Dec 18, 2025

    @gdementen
    ContributorAuthor

    Since it modifies behavior (and some models actually rely on it -- I wonder if the occurences I found are bugs in the models or not), I only added a warning, will turn that to an error in 0.36 and only change the behavior in 0.37 or possibly later for users who skip releases 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions