Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
asaraog
force-pushed
the
fix/mask-dataset-and-score-payloads
branch
from
October 2, 2026 01:07
aae4ea4 to
33ad69a
Compare
Author
|
@greptileai review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1896. Applies the client mask to create_dataset_item input/expected_output/metadata, create_dataset metadata and create_score comment, using the same fallback as span masking; those payloads bypassed mask entirely.
The PR appears safe to merge; no outstanding findings remain.
Summary
The PR applies the configured mask to dataset item payloads, dataset metadata, and score comments. It also serializes non-string masked score comments for the score API and adds focused tests.
Reviews (2) · Last reviewed commit: "fix(client): serialize non-string masked..."