Skip to content

docs(keps): align configurable preemption eviction statistics with implementation - #16324

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:mainfrom
kavix:docs-align-configurable-preemption-kep
Sep 29, 2026
Merged

docs(keps): align configurable preemption eviction statistics with implementation#16324
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:mainfrom
kavix:docs-align-configurable-preemption-kep

Conversation

@kavix

@kavix kavix commented Sep 29, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

What type of PR is this?

/kind documentation
/kind kep

What this PR does / why we need it?

Update the Configurable Preemptions KEP's Eviction Statistics section to state that WorkloadSchedulingStatsEviction.Reason is set to Preempted, consistent with the WorkloadEvicted condition and the existing preemption mechanism, rather than ConfigurablePreemption.

Fixes #16295

Useful notes for your reviewer

Follow-up to #16208 (specifically discussion #16208 (comment)) to align the KEP documentation with the implemented and tested behavior.

Release note

NONE

AI summary

Updated the Configurable Preemptions KEP to document WorkloadSchedulingStatsEviction.Reason as Preempted. UnderlyingCause remains the PreemptionConfig name.

Suggested release note

Documentation: Clarified that configurable preemption reports Preempted as the eviction statistics reason.

@kubernetes-prow kubernetes-prow Bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. kind/documentation Categorizes issue or PR as related to documentation. kind/kep Kueue Enhancement Proposal (Design) labels Sep 29, 2026
@netlify

netlify Bot commented Sep 29, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 8904b6a
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6abb4d8cf3fe0b00081e58d2

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 29, 2026
@kubernetes-prow
kubernetes-prow Bot requested review from mimowo and pajakd September 29, 2026 05:32
@kubernetes-prow kubernetes-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 29, 2026
@kavix
docs(keps): align configurable preemption eviction statistics with im…
8904b6a 
…plementation

Update the Configurable Preemptions KEP's Eviction Statistics section
to state that WorkloadSchedulingStatsEviction.Reason is set to Preempted
(consistent with WorkloadEvicted condition and existing preemption mechanism),
rather than ConfigurablePreemption.

Signed-off-by: kavix <kavix@yahoo.com>
@kavix
kavix force-pushed the docs-align-configurable-preemption-kep branch from 5971201 to 8904b6a Compare September 29, 2026 05:32
@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 29, 2026
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: kubernetes-sigs/kueue/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: de654aa5-f73e-44b5-8292-ebd19ec0efc1

📥 Commits

Reviewing files that changed from the base of the PR and between 31cc6c2 and 8904b6a.

📒 Files selected for processing (1)
  • keps/13396-configurable-preemptions/README.md

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.

📝 Walkthrough

Walkthrough

The KEP changes the documented eviction-statistics reason for configurable preemption from ConfigurablePreemption to Preempted. It retains the PreemptionConfig name as UnderlyingCause.

Changes

Configurable preemption documentation

Layer / File(s) Summary
Eviction statistics description
keps/13396-configurable-preemptions/README.md		 The documented Reason changes to Preempted. UnderlyingCause remains the PreemptionConfig name.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: dkaluza

Merge Risk: ⚪ Minimal · up to 8904b

The KEP now documents the eviction-statistics behavior consistently while preserving the distinct condition reasons; no actionable merge risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 8904b

The change affects 1 system.

Changed systems: keps

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — keps (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in keps/13396-configurable-preemptions/README.md: The documented Reason for configurable-preemption eviction statistics changes from ConfigurablePreemption to Preempted; the documented UnderlyingCause remains the causing PreemptionConfig name.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies a documentation update that aligns configurable preemption eviction statistics with the implementation. It is concise and specific.
Linked Issues check ✅ Passed The change satisfies issue #16295. In keps/13396-configurable-preemptions/README.md, the Eviction Statistics section now documents WorkloadSchedulingStatsEviction.Reason as Preempted. It keeps `…
Out of Scope Changes check ✅ Passed The pull request changes one line in the KEP Eviction Statistics documentation. The change directly implements issue #16295 and contains no unrelated code or documentation changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

mimowo
mimowo reviewed Sep 29, 2026
View reviewed changes

@mimowo mimowo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
thanks 👍

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2026
@kubernetes-prow

kubernetes-prow Bot commented Sep 29, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: 1d9e70b7da6165692de67e2a863631dc9fe4c98e

@kubernetes-prow

kubernetes-prow Bot commented Sep 29, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kavix, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2026
@dkaluza

dkaluza commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

/lgtm

Thanks!

@kubernetes-prow
kubernetes-prow Bot merged commit 735efc4 into kubernetes-sigs:main Sep 29, 2026
9 checks passed
@kubernetes-prow kubernetes-prow Bot added this to the v0.20 milestone Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mimowo mimowo mimowo left review comments
@pajakd pajakd Awaiting requested review from pajakd

Assignees

@mimowo mimowo

@dkaluza dkaluza

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. kind/kep Kueue Enhancement Proposal (Design) lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v0.20

Development

Successfully merging this pull request may close these issues.

📖 Align configurable preemption KEP eviction statistics with implementation

3 participants

@kavix @dkaluza @mimowo