queue: use cmp.Or for requeueWorkload nil fallback in TestRequeueWorkload [0.18] - #15198
Conversation
…load Replaces the explicit nil-fallback pattern for requeueWorkload in TestRequeueWorkload with the standard-library cmp.Or, which expresses the intended fallback directly. Aliases github.com/google/go-cmp/cmp as gocmp to avoid a name conflict with the newly imported standard-library cmp package. Updates all existing cmp. references in pkg/cache/queue/manager_test.go to use the gocmp alias. Cherry-pick of 697af9a from main (PR kubernetes-sigs#15168)
kubernetes-prow
Bot
added
the
release-note-none
kubernetes-prow
Bot
added
kind/cleanup
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
kubernetes-prow
Bot
added
the
cncf-cla: yes
kubernetes-prow
Bot
added
the
size/M
|
/ok-to-test |
kubernetes-prow
Bot
added
the
ok-to-test
|
/lgtm |
kubernetes-prow
Bot
added
the
lgtm
|
LGTM label has been added. DetailsGit tree hash: 1b30f31f15a8f837761e1f85b561b403e5960add |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kavix, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
approved
bd6d11a
into
kubernetes-sigs:release-0.18
|
/retitle queue: use cmp.Or for requeueWorkload nil fallback in TestRequeueWorkload [0.18] |
kubernetes-prow
Bot
changed the title
3 participants
What type of PR is this?
/kind cleanup
/area testing
What this PR does / why we need it:
Cherry-pick of #15168 onto release-0.18.
Replaces the explicit nil-fallback pattern for requeueWorkload in
TestRequeueWorkload with the standard-library cmp.Or, which expresses
the intended fallback directly.
Aliases github.com/google/go-cmp/cmp as gocmp to avoid a name conflict
with the newly imported standard-library cmp package. Updates all
existing cmp. references in pkg/cache/queue/manager_test.go to use the
gocmp alias.
AI assistance was used in creating this pull request.
Which issue(s) this PR fixes:
Cherry-pick of #15168 (original issue: #14911)
Special notes for your reviewer:
Manual cherry-pick of #15168 onto release-0.18; the automated bot failed due to merge conflicts caused by line-number drift between main and the release branch.
Does this PR introduce a user-facing change?