Skip to content

integration: Bound MultiKueue manager shutdown during teardown - #14904

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:mainfrom
kavix:bound-multikueue-manager-shutdown
Aug 29, 2026
Merged

integration: Bound MultiKueue manager shutdown during teardown#14904
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:mainfrom
kavix:bound-multikueue-manager-shutdown

Conversation

@kavix

@kavix kavix commented Aug 29, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

What type of PR is this?

/kind cleanup
/area multikueue

What this PR does / why we need it:

Bounds MultiKueue manager shutdown during integration test teardown with util.LongTimeout across the base, scheduler, and TAS suites. This prevents teardown from hanging indefinitely while preserving the order where StopManager completes before Teardown.

AI usage disclosure: Drafted and verified with the assistance of AI per Kubernetes AI Tool Usage Policy.

Which issue(s) this PR fixes:

Fixes #14898

Special notes for your reviewer:

Addresses review feedback from #14844.

Does this PR introduce a user-facing change?

NONE

Summary by CodeRabbit

  • Bug Fixes
    • Improved integration test teardown reliability by allowing manager shutdown operations additional time to complete.
    • Ensured shutdown contexts are properly released after teardown.

@kavix
integration: bound MultiKueue manager shutdown during teardown
2f72ce5 
Signed-off-by: Kavindu Sachinthe <kavix@yahoo.com>
@kubernetes-prow kubernetes-prow Bot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/multikueue Issues or PRs related to MultiKueue labels Aug 29, 2026
@netlify

netlify Bot commented Aug 29, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 2f72ce5
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6a9317dcf0cc6700084c899c
😎 Deploy Preview https://deploy-preview-14904--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 29, 2026
@kubernetes-prow

kubernetes-prow Bot commented Aug 29, 2026

Copy link
Copy Markdown

Hi @kavix. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 29, 2026
@kubernetes-prow
kubernetes-prow Bot requested review from kannon92 and mimowo August 29, 2026 17:33
@coderabbitai

coderabbitai Bot commented Aug 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e2b43c6a-35fa-44a9-8ac9-72ef4250c384

📥 Commits

Reviewing files that changed from the base of the PR and between d71094f and 2f72ce5.

📒 Files selected for processing (3)
  • test/integration/multikueue/scheduler/suite_test.go
  • test/integration/multikueue/suite_test.go
  • test/integration/multikueue/tas/suite_test.go

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Walkthrough

MultiKueue integration teardown now bounds manager shutdown with util.LongTimeout in the scheduler, TAS, and base suites. Each helper cancels the derived context after shutdown.

Changes

MultiKueue teardown

Layer / File(s) Summary
Bound manager shutdown
test/integration/multikueue/scheduler/suite_test.go, test/integration/multikueue/suite_test.go, test/integration/multikueue/tas/suite_test.go		 Each stopAndTeardown helper passes a util.LongTimeout context to StopManager and defers context cancellation before teardown.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 2f72c

This change bounds MultiKueue manager shutdown during integration-test teardown without a stated user-facing behavior change; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: nojnhuh, reckless-sherixx

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The changes satisfy issue #14898. All three affected MultiKueue suites use a context derived with util.LongTimeout, defer cancellation, pass the timeout context to StopManager, and preserve Teardown a…
Out of Scope Changes check ✅ Passed All changes are limited to the three stopAndTeardown helpers identified in issue #14898 and support bounded manager shutdown during integration test teardown.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding a bounded shutdown for MultiKueue managers during integration test teardown.
Full details: Linked Issues check

Explanation

The changes satisfy issue #14898. All three affected MultiKueue suites use a context derived with util.LongTimeout, defer cancellation, pass the timeout context to StopManager, and preserve Teardown after manager shutdown.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tenzen-y

tenzen-y commented Aug 29, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 29, 2026
tenzen-y
tenzen-y reviewed Aug 29, 2026
View reviewed changes

@tenzen-y tenzen-y left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2026
@kubernetes-prow

kubernetes-prow Bot commented Aug 29, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: 055eb477548a6ce0db7623ad84f720c600805346

@kubernetes-prow

kubernetes-prow Bot commented Aug 29, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kavix, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2026
@tenzen-y

tenzen-y commented Aug 29, 2026

Copy link
Copy Markdown
Member

/cherrypick release-0.18
/cherrypick release-0.19

@k8s-infra-cherrypick-robot

k8s-infra-cherrypick-robot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

@tenzen-y: once the present PR merges, I will cherry-pick it on top of release-0.18, release-0.19 in new PRs and assign them to you.

Details

In response to this:

/cherrypick release-0.18
/cherrypick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow
kubernetes-prow Bot merged commit 77c0c5c into kubernetes-sigs:main Aug 29, 2026
61 checks passed
@kubernetes-prow kubernetes-prow Bot added this to the v0.20 milestone Aug 29, 2026
@k8s-infra-cherrypick-robot

k8s-infra-cherrypick-robot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

@tenzen-y: new pull request created: #14906

Details

In response to this:

/cherrypick release-0.18
/cherrypick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Aug 29, 2026
Merged
@k8s-infra-cherrypick-robot

k8s-infra-cherrypick-robot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

@tenzen-y: new pull request created: #14907

Details

In response to this:

/cherrypick release-0.18
/cherrypick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Aug 29, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tenzen-y tenzen-y tenzen-y left review comments
@kannon92 kannon92 Awaiting requested review from kannon92
@mimowo mimowo Awaiting requested review from mimowo

Assignees

@tenzen-y tenzen-y

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/multikueue Issues or PRs related to MultiKueue cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v0.20

Development

Successfully merging this pull request may close these issues.

integration: Bound MultiKueue manager shutdown during teardown

3 participants

@kavix @tenzen-y @k8s-infra-cherrypick-robot