Skip to content

metrics: correct comment on RecordPodSchedulingGateRemovalSeconds - #14740

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:mainfrom
kavix:fix-scheduling-gate-metric-comment
Aug 23, 2026
Merged

metrics: correct comment on RecordPodSchedulingGateRemovalSeconds#14740
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:mainfrom
kavix:fix-scheduling-gate-metric-comment

Conversation

@kavix

@kavix kavix commented Aug 23, 2026

Copy link
Copy Markdown
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates the comment for RecordPodSchedulingGateRemovalSeconds in pkg/metrics/metrics.go to clarify that WorkloadAdmitted.LastTransitionTime is set by the Kueue controller manager rather than the Kubernetes API server, while explaining why clock skew across leader handoffs or wall-clock adjustments can still result in negative latency.

Which issue(s) this PR fixes:

Fixes #14730

Special notes for your reviewer:

AI usage disclosure: AI assistant was used to draft the comment and PR description.

Does this PR introduce a user-facing change?

NONE

@kubernetes-prow kubernetes-prow Bot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Aug 23, 2026
@netlify

netlify Bot commented Aug 23, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 14819b4
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6a8a96cb34218c00086a7ddd

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 23, 2026
@kubernetes-prow

kubernetes-prow Bot commented Aug 23, 2026

Copy link
Copy Markdown

Hi @kavix. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai

coderabbitai Bot commented Aug 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Excluded labels (none allowed) (3)
  • needs-ok-to-test
  • do-not-merge/work-in-progress
  • cncf-cla: no

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5f1a802c-31a7-41fb-90db-3a20fa60afd4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kubernetes-prow kubernetes-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 23, 2026
@kavix
metrics: update comment on RecordPodSchedulingGateRemovalSeconds
14819b4 
Update the comment in RecordPodSchedulingGateRemovalSeconds to clarify that
WorkloadAdmitted.LastTransitionTime is set by the Kueue controller manager
rather than the API server, while explaining why clock skew can still result
in negative latency.
@kavix
kavix force-pushed the fix-scheduling-gate-metric-comment branch from 6d71adb to 14819b4 Compare August 23, 2026 06:44
@kavix kavix mentioned this pull request Aug 23, 2026
Closed
11 tasks done
@tenzen-y

tenzen-y commented Aug 23, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 23, 2026
tenzen-y
tenzen-y reviewed Aug 23, 2026
View reviewed changes

@tenzen-y tenzen-y left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2026
@kubernetes-prow

kubernetes-prow Bot commented Aug 23, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: 4d44340bd07ccb43eae5a6c3f77b1b3083702f87

@kubernetes-prow

kubernetes-prow Bot commented Aug 23, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kavix, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2026
@tenzen-y

tenzen-y commented Aug 23, 2026

Copy link
Copy Markdown
Member

/cherrypick release-0.19

@k8s-infra-cherrypick-robot

k8s-infra-cherrypick-robot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

@tenzen-y: once the present PR merges, I will cherry-pick it on top of release-0.19 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow
kubernetes-prow Bot merged commit 633666f into kubernetes-sigs:main Aug 23, 2026
57 checks passed
@kubernetes-prow kubernetes-prow Bot added this to the v0.20 milestone Aug 23, 2026
@k8s-infra-cherrypick-robot

k8s-infra-cherrypick-robot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

@tenzen-y: new pull request created: #14750

Details

In response to this:

/cherrypick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Aug 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tenzen-y tenzen-y tenzen-y left review comments
@PBundyra PBundyra Awaiting requested review from PBundyra
@sohankunkerkar sohankunkerkar Awaiting requested review from sohankunkerkar

Assignees

@tenzen-y tenzen-y

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v0.20

Development

Successfully merging this pull request may close these issues.

Correct the timestamp-source comment for pod scheduling-gate latency

3 participants

@kavix @tenzen-y @k8s-infra-cherrypick-robot