Remove unused resource.IsZero function by kavix · Pull Request #14546 · kubernetes-sigs/kueue

kavix · 2026-08-17T09:20:27Z

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Removes the unused IsZero function from pkg/util/resource.

Which issue(s) this PR fixes:

Fixes #14545

Special notes for your reviewer:

This pull request was prepared with AI assistance.

Does this PR introduce a user-facing change?

NONE

netlify · 2026-08-17T09:20:33Z

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	`bdb5e0c`
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6a83ff86b89e1b00074e5b34

linux-foundation-easycla · 2026-08-17T09:20:35Z

The committers listed above are authorized under a signed CLA.

✅ login: kavix / name: Kavindu Sachinthe (19f5b95)

kubernetes-prow · 2026-08-17T09:20:37Z

Welcome @kavix!

It looks like this is your first PR to kubernetes-sigs/kueue 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kueue has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

kubernetes-prow · 2026-08-17T09:20:38Z

Hi @kavix. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

coderabbitai · 2026-08-17T09:20:45Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d37d9aa0-21a6-4628-9864-8058b27af1a0

📥 Commits

Reviewing files that changed from the base of the PR and between 456c96f and bdb5e0c.

📒 Files selected for processing (1)

pkg/util/resource/resource.go

💤 Files with no reviewable changes (1)

pkg/util/resource/resource.go

Included review availability: Your plan includes up to 8 reviews per rolling hour; 7 remain after this review.

📝 Walkthrough

Walkthrough

The exported IsZero helper was removed from pkg/util/resource/resource.go. Extended-resource detection remains unchanged.

Changes

Resource helper removal

Layer / File(s)	Summary
Remove `IsZero` helper `pkg/util/resource/resource.go`	Removes the unused exported `IsZero` function and its empty-list and zero-quantity checks.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to bdb5e

This localized fix makes zero-valued non-empty ResourceLists evaluate correctly, with no actionable merge-blocking risk remaining beyond normal checks and review.

Suggested reviewers: kannon92

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	The change removes IsZero but does not implement the documented zero-only ResourceList behavior or add the requested regression test [`#14545`].	Implement IsZero so empty and zero-only lists return true, mixed lists return false, and add focused regression tests.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Out of Scope Changes check	✅ Passed	The only reported change removes the IsZero helper, which is directly related to the linked issue and contains no unrelated code changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the removed unused `resource.IsZero` function, which is the only change in the provided changeset.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

mbobrovskyi · 2026-08-18T05:15:46Z

/ok-to-test

pajakd · 2026-08-18T13:10:41Z

Please fix the PR description, title and set the relnotes to NONE.

kavix · 2026-08-18T14:11:43Z

Please fix the PR description, title and set the relnotes to NONE.

Updated the PR title, description, kind to cleanup, and set the release notes to NONE. Thanks!

tenzen-y · 2026-08-18T15:28:05Z

/kind cleanup

tenzen-y · 2026-08-18T15:28:09Z

/remove-kind bug

tenzen-y

Thank you.
/lgtm
/approve

kubernetes-prow · 2026-08-18T15:28:28Z

LGTM label has been added.

Details

Git tree hash: 605be17f4f4a4fbc2581377e359577d4306ddc01

kubernetes-prow · 2026-08-18T15:28:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kavix, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubernetes-prow Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Aug 17, 2026

kubernetes-prow Bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 17, 2026

kubernetes-prow Bot requested review from kannon92 and mbobrovskyi August 17, 2026 09:20

kubernetes-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 17, 2026

kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 17, 2026

kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 18, 2026

mbobrovskyi reviewed Aug 18, 2026

View reviewed changes

Comment thread pkg/util/resource/resource.go

mbobrovskyi mentioned this pull request Aug 18, 2026

Remove the unused IsZero() function #14545

Closed

Remove unused resource.IsZero function

bdb5e0c

kavix force-pushed the issue-14545 branch from 19f5b95 to bdb5e0c Compare August 18, 2026 06:45

kubernetes-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 18, 2026

kavix requested a review from mbobrovskyi August 18, 2026 06:45

kavix changed the title ~~Fix resource.IsZero returning false for zero-valued ResourceLists~~ Remove unused resource.IsZero function Aug 18, 2026

kubernetes-prow Bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 18, 2026

kubernetes-prow Bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 18, 2026

kubernetes-prow Bot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 18, 2026

kubernetes-prow Bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 18, 2026

kubernetes-prow Bot removed the kind/bug Categorizes issue or PR as related to a bug. label Aug 18, 2026

tenzen-y reviewed Aug 18, 2026

View reviewed changes

kubernetes-prow Bot assigned tenzen-y Aug 18, 2026

kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2026

kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2026

kubernetes-prow Bot merged commit fbb60cc into kubernetes-sigs:main Aug 18, 2026
56 checks passed

kubernetes-prow Bot added this to the v0.20 milestone Aug 18, 2026

kavix mentioned this pull request Aug 23, 2026

REQUEST: New membership for kavix kubernetes/org#6573

Closed

11 tasks done

Conversation

kavix commented Aug 17, 2026 • edited by tenzen-y Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

netlify Bot commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Uh oh!

linux-foundation-easycla Bot commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kubernetes-prow Bot commented Aug 17, 2026

Uh oh!

kubernetes-prow Bot commented Aug 17, 2026

Uh oh!

coderabbitai Bot commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

mbobrovskyi commented Aug 18, 2026

Uh oh!

Uh oh!

pajakd commented Aug 18, 2026

Uh oh!

kavix commented Aug 18, 2026

Uh oh!

tenzen-y commented Aug 18, 2026

Uh oh!

tenzen-y commented Aug 18, 2026

Uh oh!

tenzen-y left a comment

Choose a reason for hiding this comment

Uh oh!

kubernetes-prow Bot commented Aug 18, 2026

Uh oh!

kubernetes-prow Bot commented Aug 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kavix commented Aug 17, 2026 •

edited by tenzen-y

Loading

netlify Bot commented Aug 17, 2026 •

edited

Loading

linux-foundation-easycla Bot commented Aug 17, 2026 •

edited

Loading

coderabbitai Bot commented Aug 17, 2026 •

edited

Loading