Skip to content

Tags: ksnip/ksnip

Tags

continuous

Toggle continuous's commit message

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Fix: "Print to File" pre-checked by default on Windows (#1184)

* Fix: don't pre-enable print-to-file before showing the print dialog

CapturePrinter::print() and printPreview() called
printer.setOutputFileName(defaultPath) with a real .pdf path before
opening QPrintDialog, even though setOutputFormat(NativeFormat) was
called right after. On Windows, Qt's PPK_OutputFileName property
handler in qprintengine_win.cpp sets the internal printToFile flag to
true for any non-empty filename, independent of the later
setOutputFormat() call. That flag drives the PD_PRINTTOFILE flag,
which pre-checks "Print to File" in the native dialog regardless of
printer or Windows settings (see discussion #1111).

Removed the setOutputFileName() calls; defaultPath is now unused
(Q_UNUSED) to keep the function signature stable.

* Refactor print methods to remove defaultPath parameter

Removed unused parameter 'defaultPath' from print and printPreview methods.

* Refactor print methods in CapturePrinter class

* Refactor print methods to remove save path

Removed save path parameter from print and print preview methods.

v1.10.1

Toggle v1.10.1's commit message
Prepare version v1.10.1 release

v1.10.0

Toggle v1.10.0's commit message
Set correct dependency versions prior to release

v1.9.2

Toggle v1.9.2's commit message
Export version regex variable

v1.9.1

Toggle v1.9.1's commit message
Run pipeline on tagged pushes

v1.9.0

Toggle v1.9.0's commit message
Finish up version 1.9.0

v1.8.2

Toggle v1.8.2's commit message
Fix macos ci build

v1.8.1

Toggle v1.8.1's commit message
Use specific dependnecy version for snapcraft

v1.8.0

Toggle v1.8.0's commit message
Update readme file

v1.7.3

Toggle v1.7.3's commit message
Update appData