Skip to content

feat(cache): Updated cache action to v4 - #15

Closed
devlsat wants to merge 2 commits into
kishaningithub:mainfrom
devlsat:patch-1
Closed

devlsat wants to merge 2 commits into
kishaningithub:mainfrom
devlsat:patch-1

Conversation

@devlsat

@devlsat devlsat commented Aug 7, 2024

Copy link
Copy Markdown

No description provided.

@kishaningithub

Copy link
Copy Markdown
Owner

Can you kindly rebase your PR with the main branch once? It should trigger a CI CD run.

@devlsat

devlsat commented Aug 7, 2024

Copy link
Copy Markdown
Author

Can you kindly rebase your PR with the main branch once? It should trigger a CI CD run.

I am not able to rebase, maybe due to lack of write access. Was just able to fork and create PR.
You can just update it in your next release if it's possible.

@kishaningithub

Copy link
Copy Markdown
Owner

If you point the git remote config to your fork you should be able to rebase

@devlsat

devlsat commented Aug 7, 2024 •

Copy link
Copy Markdown
Author

Hi plz check now: https://github.com/kishaningithub/setup-python-amazon-linux/actions/runs/10283471178

@kishaningithub

Copy link
Copy Markdown
Owner

This node js change is breaking amazon linux 2 because it has an older version of GLIBC. What is the version of amazon linux are you using?

Error screenshot

image

@devlsat

devlsat commented Aug 8, 2024 •

Copy link
Copy Markdown
Author

I am on the Amazon Linux 2023. Yes, there are breaking changes, due to the older version GLIBC 2.26 being used in Amazon Linux 2

@kishaningithub

Copy link
Copy Markdown
Owner

You have any suggestions to fix this?

@devlsat

devlsat commented Aug 9, 2024

Copy link
Copy Markdown
Author

You have any suggestions to fix this?

No idea, since it's on the Amazon side.

@kishaningithub

Copy link
Copy Markdown
Owner

One idea I am planning to explore

What if I remove the cache action and replace it with direct curl calls

That way I don't have to publish separate versions based on the Amazon Linux version

@devlsat

devlsat commented Aug 12, 2024

Copy link
Copy Markdown
Author

One idea I am planning to explore

What if I remove the cache action and replace it with direct curl calls

That way I don't have to publish separate versions based on the Amazon Linux version

Oh, that should work, would make it simpler as well to maintain in the longer run.

@devlsat

devlsat commented Aug 13, 2024

Copy link
Copy Markdown
Author

Closing the pr

@devlsat devlsat closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants