Skip to content

⚡ Bolt: optimize ZRLE decoding and CopyRect performance - #38

Open
kimocoder wants to merge 1 commit into
kalifrom
bolt-zrle-vnc-optimization-4172107105787243038
Open

kimocoder wants to merge 1 commit into
kalifrom
bolt-zrle-vnc-optimization-4172107105787243038

Conversation

@kimocoder

Copy link
Copy Markdown
Owner

Optimized ZRLE decoding and CopyRect performance in the X11/VNC client by reducing arithmetic overhead and GC pressure.


PR created automatically by Jules for task 4172107105787243038 started by @kimocoder

This commit introduces several performance optimizations for X11/VNC rendering:

1.  **ZRLE Decoder Optimizations:**
    *   Promoted `ZInput` to a persistent member of `ZrleDecoder` to reuse its 16KB decompression buffer across rectangles, significantly reducing GC pressure.
    *   Inlined the `avail == 0` check in `ZInput.readByte()` to minimize function call overhead in the hot path.
    *   Implemented strength reduction in `decodeTile` and all subencoding decoders (Raw, Solid, Packed Palette, RLE, Palette RLE) by replacing repeated multiplications and division/modulo operations with incremental row and column counters.
    *   Optimized `ZInput.readCpixel()` to perform direct 3-byte component reads from the internal buffer when available.

2.  **VncClient Optimizations:**
    *   Refactored `ENC_RAW` and `ENC_COPY_RECT` rendering loops to use incremental `rowBase`, `srcRowBase`, and `dstRowBase` pointers, eliminating redundant multiplications per row.
    *   Ensured correct iteration direction in `ENC_COPY_RECT` for overlapping regions.

These changes target the most CPU-intensive parts of the VNC protocol handling on Android (especially ARM architectures), where integer division and repeated coordinate arithmetic are significant bottlenecks.

Tests:
*   `./gradlew :app:testDebugUnitTest --tests "com.excp.podroid.x11.ZrleDecoderTest"`
*   `./gradlew :app:testDebugUnitTest --tests "com.excp.podroid.x11.VncClientTest"`
*   `./gradlew :app:testDebugUnitTest` (full app module suite)

Verification:
*   Verified that all ZRLE subencodings (Raw, Solid, Packed Palette, RLE, Palette RLE) decode correctly.
*   Verified that CopyRect handles overlapping and non-overlapping rectangles correctly.

Co-authored-by: kimocoder <4252297+kimocoder@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant