Repository navigation
siputils: walk back from the uri in contact_param_encode() - #4966
Merged
miconda merged 1 commit intoSep 30, 2026
Merged
Conversation
- the loop looking for '<' before the contact uri started one char before it but advanced with p++, so it stepped into the uri and stopped there; walk backwards instead - the whitespace check tested '\n' twice, the second one meant '\r'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
clang-formatusing the config file.clang-formatfrom source code folder
in
doc/subfolder, the README file is autogenerated)Type Of Change
Checklist:
Description
Spotted this next to the tm one. The loop should walk back from the uri looking for '<', but with p++ it steps into the uri and stops with q=1. A plain
<sip:...>still works since '<' is right before the uri, but I think< sip:...>would get a second pair of brackets. Checked the loop alone on a few header strings, not a full run.