Conversation
Lets trusted local integrations use networking and external state without inheriting model-tool restrictions. Adds regression coverage to keep hooks independent from read-only and workspace-write policies.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run configured project hooks through a full-access execution boundary instead of inheriting the model-tool command sandbox.
This keeps project hooks usable from subagent turns when they need networking or access to external local integrations, while preserving the existing sandbox behavior for ordinary model-generated commands and project commands.
Why
The upstream codex-rs hook runtime executes configured hooks separately from the model-tool sandbox. code-rs does not yet have that split runtime, so this applies the equivalent policy at the existing hook execution boundary.
Previously, hooks inherited the active session sandbox. In restricted modes, that could prevent hooks from accessing networking or other external state even though the hook was explicitly configured by the project.
Scope
SandboxType::NonewithDangerFullAccess.config.tomlsetting is introduced.Validation
./build-fast.sh --workspace code1.90.0dev-fastprofile