Conversation
The user may also define JSON_POW and JSON_POW_HEADER so that the correct pow function is used.
LB--
added a commit
to LB--/json-builder
that referenced
this pull request
Mar 27, 2018
Member
Author
|
After seeing #103 I think my PR here needs further consideration before being merged... I'll have to rebase this work anyway |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the modified
README.mdfor details. The use ofpowis problematic becausepowland<tgmath.h>are not available until C99, so I had to addJSON_POWandJSON_POW_HEADERto let people work around that in C89 and C94 (and MSVC if they choose to compile as C). Alternatively, we could replacepowusage with repeated multiplication - up to you.I'll create a similar pull request for
json-builderif you are willing to go forward with this.