Only refuse to resume fibers suspended by a transfer - #9765
Merged
Merged
Conversation
A fiber that had ever been transferred into could never be resumed again. The fiber scheduler transfers an Enumerator's fiber away and back when it sleeps, so the next Enumerator#next raised "attempt to resume a transferring fiber", which broke Async's enumerator tests. Follow MRI's fiber_resume_kw: refuse only a started fiber that isn't parked in Fiber.yield.
headius
approved these changes
Oct 2, 2026
Member
|
Yup makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fiber that had ever been transferred into could never be resumed again. The fiber scheduler transfers an Enumerator's fiber away and back when it sleeps, so the next Enumerator#next raised "attempt to resume a transferring fiber", which broke Async's enumerator tests.
Follow MRI's fiber_resume_kw: refuse only a started fiber that isn't parked in Fiber.yield.
This test from Async now passes: https://github.com/socketry/async/blob/d8f59c95c3083558aa543101ee5fdcc006054f4d/test/enumerator.rb#L46-L51