Wait for another thread's require of an autoload's file - #9764
Merged
Merged
Conversation
Autoload skipped loading while its file was being required, even when the require was on another thread. If two constants autoload the same file and it raises, the second thread then got NameError instead of the file's error, as TestAutoload#test_autoload_same_file_with_raise sometimes shows in CI. Only skip for the current thread's own require. Otherwise wait for the other load through autoloadRequire, like MRI.
headius
approved these changes
Oct 2, 2026
Member
|
Autoload lifecycle is annoyingly complex. Thanks for the patch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autoload skipped loading while its file was being required, even when the require was on another thread. If two constants autoload the same file and it raises, the second thread then got NameError instead of the file's error, as TestAutoload#test_autoload_same_file_with_raise sometimes shows in CI.
Only skip for the current thread's own require. Otherwise wait for the other load through autoloadRequire, like MRI.