Interrupt fibers waiting through the scheduler when their IO closes - #9760
Merged
Merged
Conversation
IO#close interrupted threads blocked on the IO, but not fibers parked in the fiber scheduler's io_wait, so they kept waiting on a closed IO. Track those waits and, after releasing the IO lock, hand each fiber an IOError through the scheduler's fiber_interrupt, or raise it in the fiber's thread if the scheduler has no such hook, like MRI. This lets TestFiberIOClose#test_io_close_across_fibers run again.
headius
requested changes
Oct 1, 2026
headius
left a comment
headius
left a comment
Member
There was a problem hiding this comment.
On minor change but it looks good.
headius
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IO#close interrupted threads blocked on the IO, but not fibers parked in the fiber scheduler's io_wait, so they kept waiting on a closed IO. Track those waits and, after releasing the IO lock, hand each fiber an IOError through the scheduler's fiber_interrupt, or raise it in the fiber's thread if the scheduler has no such hook, like MRI.
This lets TestFiberIOClose#test_io_close_across_fibers run again. It was just disabled in #9750.