Skip to content

Raise IOError, not NullPointerException, when an IO is closed during accept #9716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
headius merged 3 commits into from
Sep 20, 2026
Merged

Raise IOError, not NullPointerException, when an IO is closed during accept #9716

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c826bba
Read the IO fd field once when handing out its channel
aminmansuri Sep 18, 2026
fa351a9
Make the IO fd field volatile
aminmansuri Sep 19, 2026
203eb0a
Read the IO fd field once for fileno and tty?
aminmansuri Sep 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make the IO fd field volatile 
The accessors read it outside the lock while close writes it under the lock,
so without this the close is not guaranteed visible and the ChannelFD handed
out is not safely published.
  • Loading branch information
@aminmansuri
aminmansuri committed Sep 19, 2026
commit fa351a957823e3e4eba4c7b7605b48f410ef3fa3
4 changes: 3 additions & 1 deletion core/src/main/java/org/jruby/util/io/OpenFile.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,9 @@ public static interface Finalizer {
public void finalize(Ruby runtime, OpenFile fptr, boolean noraise);
}

private ChannelFD fd;
// volatile so a close in another thread is visible to the accessors below, which read fd
// outside the lock, and so the ChannelFD they hand out is safely published.
private volatile ChannelFD fd;
private int mode;
private long pid = -1;
private Process process;
Expand Down