Skip to content

Convert newlines in text mode on Windows through the transcoder #9707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aminmansuri wants to merge 9 commits into
base: jruby-10.0
Choose a base branch
from
Open

Convert newlines in text mode on Windows through the transcoder #9707

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1f1d323
Cover Windows text-mode newline conversion in specs and tests
aminmansuri Sep 16, 2026
7d4173c
Convert newlines in text mode on Windows through the transcoder
aminmansuri Sep 17, 2026
455afb4
Start a new ARGF instance in text mode
aminmansuri Sep 17, 2026
8aa5272
Tag the IO specs the Windows CRLF checkout cannot satisfy
aminmansuri Sep 17, 2026
46f2144
Tag the ARGF.readchar byte-level example on Windows too
aminmansuri Sep 17, 2026
8e9dfd3
Keep pipe write ends raw in Windows text mode
aminmansuri Sep 17, 2026
a863407
Report the caller's byte count from text-mode writes on Windows
aminmansuri Sep 17, 2026
5c16885
Use Console#isTerminal to detect a Windows console
aminmansuri Sep 17, 2026
9a3974a
Close the file in the text-mode write count spec
aminmansuri Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Close the file in the text-mode write count spec
  • Loading branch information
@aminmansuri
aminmansuri committed Sep 17, 2026
commit 9a3974a296570f40268af01e87c3afaaa48bb47c
1 change: 1 addition & 0 deletions spec/ruby/core/io/write_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,7 @@
it "returns the number of bytes given, not the number written, in text mode" do
@io = new_io(@fname, "w")
@io.write("a\nb\n").should == 4
@io.close
end

it "does not normalize line endings in binary mode" do
Expand Down
Loading