Report whether a line was actually counted

IRRuntimeHelpers.coverLine promised "true if the line was counted" but returned true as soon as coverage was running, before CoverageData decided whether it had anywhere to put the count. CoverageData.coverLine gives up silently on a negative line, an untracked file, a file with no line counts, and a line past the end of them. Both callers now act on that answer: the interpreter and the indy coverage site disarm a oneshot probe once the line is counted, so a probe whose line had nowhere to go disarmed itself and lost the line for good. It now stays armed, which is what the caller already assumed.
headius · Sep 30, 2026 · Sep 14, 2026 · Sep 14, 2026 · Sep 14, 2026 · Sep 14, 2026
commit 533a68ad869541e6b9c62b38a290bfa73d2b5514
diff --git a/core/src/main/java/org/jruby/ext/coverage/CoverageData.java b/core/src/main/java/org/jruby/ext/coverage/CoverageData.java
@@ -119,31 +119,35 @@ public Map<String, FileCoverage> getCoverage() {
     /**
      * Update coverage data for the given file and line number.
      *
-     * @param filename
-     * @param line
+     * @param filename the file the line belongs to
+     * @param line zero-based line number
+     * @return true if the line was counted. False if there is nowhere to count it: a negative line, an
+     *         untracked file, a file with no line counts, or a line past the end of them.
      */
-    public synchronized void coverLine(String filename, int line) {
+    public synchronized boolean coverLine(String filename, int line) {
         Map<String, FileCoverage> coverage = this.coverage;
 
+        if (coverage == null) return false;
+
         // negative lines are not included in coverage
-        if (line < 0) return;
+        if (line < 0) return false;
 
-        if (coverage != null) {
-            FileCoverage file = coverage.get(filename);
+        FileCoverage file = coverage.get(filename);
 
-            if (file == null) return;
+        if (file == null) return false;
 
-            IntList lines = file.getLines();
+        IntList lines = file.getLines();
 
-            if (lines == null) return;
+        if (lines == null) return false;
 
-            if (isOneshot()) {
-                lines.add(line);
-            } else {
-                if (lines.size() <= line) return;
-                lines.set(line, lines.get(line) + 1);
-            }
+        if (isOneshot()) {
+            lines.add(line);
+        } else {
+            if (lines.size() <= line) return false;
+            lines.set(line, lines.get(line) + 1);
         }
+
+        return true;
     }
 
     /**

diff --git a/core/src/main/java/org/jruby/ir/runtime/IRRuntimeHelpers.java b/core/src/main/java/org/jruby/ir/runtime/IRRuntimeHelpers.java
@@ -720,9 +720,7 @@ public static boolean coverLine(ThreadContext context, String filename, int line
 
         if (!data.isRunning()) return false;
 
-        data.coverLine(filename, line);
-
-        return true;
+        return data.coverLine(filename, line);
     }
 
     @JIT @Interp