Use CRuby logic for exec - #9627
Merged
Merged
Conversation
headius
force-pushed
the
exec_use_popen_logic
branch
2 times, most recently
from
September 1, 2026 23:13
7c5c2ad to
73eed45
Compare
headius
force-pushed
the
exec_use_popen_logic
branch
from
September 2, 2026 06:25
73eed45 to
e05d38f
Compare
The logic ported from CRuby for spawn and popen is also used for exec, but we never hooked that up. This fills in the last pieces and connects up that logic to Process.exec. Fixes jruby#9609
headius
force-pushed
the
exec_use_popen_logic
branch
from
September 2, 2026 07:00
e05d38f to
697fff5
Compare
Follow-up work for jruby#9609, also connecting Kernel.exec to the updated CRuby process logic. This includes a large refactoring that moves the old logic into Helpers and deprecates the old entry points for that logic. The old logic will only be used when one of the following is true: * Running on Windows, for which we have minimal native process support and no direct support in the CRuby logic * Running with NATIVE_EXEC disabled * Running without native POSIX support Additional utility methods needed to support the old logic were also refactored and moved to Helpers.
headius
force-pushed
the
exec_use_popen_logic
branch
from
September 2, 2026 07:21
697fff5 to
82b5fd9
Compare
headius
force-pushed
the
exec_use_popen_logic
branch
from
September 2, 2026 07:39
82b5fd9 to
258cd96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This wires up the CRuby process logic to exec, fixing a number of issues and cleaning up some old code.
This is a follow-up to #9626 which fixed the handling of nil-or-boolean flags to
popenandspawnbut sinceexecdid not use that logic it did not fix the reported issue in #9609.Fixes #9609