Repository navigation
Tests write to testOutput without creating it, so they depend on test order #108
Description
Activity
Fixed on
developfor 2.2.7 in de24032 and onv3-developfor 3.0.1 in 2ceef13:TestUtil.testOutputPath(name)createstestOutputand returns the path, and every affected test uses it. Each was checked to pass when run on its own with notestOutputdirectory.A correction to the description: in 3.x,
KdbxFileSaveAndReloadTestandProtectedPropertyTest2didn't actually fail, because every class that uses them extendsDatabaseTestBase, which creates the directory. They relied on that silently, so they use the helper now too. OnlyIssue87TestandIssue88Testwere order-dependent in 3.x.QuickStartin 2.x also wrotemigration.kdbxwithout creating the directory; it now creates it.
Several tests write files into
testOutputwithout creating that directory first. They pass only when some other test has already created it, so whether they pass depends on test order. This surfaced when the 2.x build first ran on GitHub Actions, whereIssue88Testran early and failed:Affected:
Issue87Test,Issue88TestandSimpleQuickStartTestinexample.QuickStart.ensureOutputDir()existed but was never called, andPropertyValueChecksandSaveAndReloadCheckseach had their own copy.Issue87Test,Issue88Test,KdbxFileSaveAndReloadTestandProtectedPropertyTest2.Fix
Add one shared helper to
TestUtil(inutilfor 2.x,testfor 3.x) that returns a path intestOutputand creates the directory, and use it in every test that writes output, replacing the separate copies. Check each affected test passes when run on its own with notestOutputdirectory.