Add ARIA roles to Tippy dropdowns for screen reader support - #26321
SalmanDeveloperz wants to merge 4 commits into
Conversation
|
Yay, your first pull request towards Jenkins core was created successfully! Thank you so much! |
|
This does not work in my testing I didn't notice any difference. I looked at your after video and you are using a version over a year old in your fixed version, please apply the change directly to master and test there. |
|
Thanks for the lint fix ! Rebased on master and retested with latest. The fix works as expected, Orca now announces dropdown menu for Manage Jenkins, opens menu when focused on the trigger and announces when navigating with arrow keys. Attaching updated test recording: output.mp4 |
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
0105e7d to
ce5d789
Compare
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
|
Hey, just following up since it's been a few months and all checks are green; |
|
You have 3 linting issues and conflicts. |
|
Addressed the merge conflicts and linting issues. Merged the latest |
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
Fixes #26296
Testing done
Tested manually with Orca screen reader on Ubuntu 24.04.
Before
2026-02-17.output.mp4
After
2026-02-18.output.mp4
Proposed changelog entries
Improve screen reader support for dropdown menus
Proposed changelog category
/label bug
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@timja
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.