Skip to content

Add ARIA roles to Tippy dropdowns for screen reader support - #26321

Open
SalmanDeveloperz wants to merge 4 commits into
jenkinsci:masterfrom
SalmanDeveloperz:fix-tippy-aria-accessibility
Open

SalmanDeveloperz wants to merge 4 commits into
jenkinsci:masterfrom
SalmanDeveloperz:fix-tippy-aria-accessibility

Conversation

@SalmanDeveloperz

Copy link
Copy Markdown
Contributor

Fixes #26296

Testing done

Tested manually with Orca screen reader on Ubuntu 24.04.

Before

  • Navigating breadcrumb dropdowns with arrow keys, individual items were not announced.
  • Couldn't tell if expanded or collapsed.
2026-02-17.output.mp4

After

  • Dropdown trigger announces: "Manage Jenkins, list with items"
  • Navigation with arrow keys provides clear audio feedback for popup items.
  • Announced expanded or collapsed on action correctly.
2026-02-18.output.mp4

Proposed changelog entries

Improve screen reader support for dropdown menus

Proposed changelog category

/label bug

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@timja

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

@welcome

welcome Bot commented Feb 17, 2026

Copy link
Copy Markdown

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@comment-ops-bot comment-ops-bot Bot added the bug For changelog: Minor bug. Will be listed after features label Feb 17, 2026
@janfaracik
janfaracik self-requested a review February 18, 2026 09:48
@timja

timja commented Feb 18, 2026

Copy link
Copy Markdown
Member

This does not work in my testing I didn't notice any difference.

I looked at your after video and you are using a version over a year old in your fixed version, please apply the change directly to master and test there.

@SalmanDeveloperz

Copy link
Copy Markdown
Contributor Author

Thanks for the lint fix !

Rebased on master and retested with latest. The fix works as expected, Orca now announces dropdown menu for Manage Jenkins, opens menu when focused on the trigger and announces when navigating with arrow keys.

Attaching updated test recording:

output.mp4

@github-actions github-actions Bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Mar 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Please take a moment and address the merge conflicts of your pull request. Thanks!

@SalmanDeveloperz
SalmanDeveloperz force-pushed the fix-tippy-aria-accessibility branch from 0105e7d to ce5d789 Compare April 2, 2026 19:59
@github-actions github-actions Bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Apr 2, 2026
@github-actions github-actions Bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Apr 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Please take a moment and address the merge conflicts of your pull request. Thanks!

@MarkEWaite MarkEWaite added the web-ui The PR includes WebUI changes which may need special expertise label May 13, 2026
@SalmanDeveloperz

Copy link
Copy Markdown
Contributor Author

Hey, just following up since it's been a few months and all checks are green;
LMK if this is good to go! Thanks

@timja

timja commented Jul 7, 2026

Copy link
Copy Markdown
Member

You have 3 linting issues and conflicts.

@github-actions github-actions Bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Jul 16, 2026
@SalmanDeveloperz

Copy link
Copy Markdown
Contributor Author

Addressed the merge conflicts and linting issues. Merged the latest upstream/master and all checks are passing now. LMK if there's anything else to update. Thankss

@github-actions

Copy link
Copy Markdown
Contributor

Please take a moment and address the merge conflicts of your pull request. Thanks!

@github-actions github-actions Bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug For changelog: Minor bug. Will be listed after features unresolved-merge-conflict There is a merge conflict with the target branch. web-ui The PR includes WebUI changes which may need special expertise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tippy dropdown content not announced in voiceover

3 participants