Respect EnableSubtitleExtraction setting in subtitle delivery - #16380
Merged
Merged
Conversation
LTe
force-pushed
the
fix-subtitle-extraction-setting
branch
from
March 10, 2026 08:21
10dd218 to
7a194b0
Compare
LTe
force-pushed
the
fix-subtitle-extraction-setting
branch
2 times, most recently
from
March 13, 2026 15:32
d7857ba to
23e8d22
Compare
Wire up EnableSubtitleExtraction config to MediaEncoder.CanExtractSubtitles so the setting is actually respected. Gate subtitle extraction check behind PlayMethod.Transcode since DirectPlay has no competing ffmpeg process. Add parameterized tests for StreamBuilder.GetSubtitleProfile covering text and graphical codecs, profile format matching, and extraction setting behavior. Remove misplaced SubtitleEncoder extraction test.
LTe
force-pushed
the
fix-subtitle-extraction-setting
branch
from
March 13, 2026 15:34
23e8d22 to
37983c9
Compare
|
nyanmisaka
approved these changes
Mar 26, 2026
nyanmisaka
left a comment
nyanmisaka
left a comment
Member
There was a problem hiding this comment.
This seems to make sense. I applied it locally and did some testing, and it doesn't appear to cause any regressions in PlayMethod.Transcode.
Shadowghost
approved these changes
Mar 26, 2026
This was referenced Apr 6, 2026
gnattu
approved these changes
Apr 11, 2026
Bond-009
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Make
MediaEncoder.CanExtractSubtitles()check theEnableSubtitleExtractionencoding option instead of always returningtrue. This causesStreamBuilderto select burn-in (Encode) instead of external delivery for embedded subtitles during transcoding, preventing a separate ffmpeg extraction process from competing with the transcode for network bandwidth.The check is scoped to transcoding only — during DirectPlay, subtitle extraction is still allowed since there is no competing transcode process.
Issues
Fixes #1163
Related #935