Skip to content

Ninja code #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joaquinelio merged 19 commits into from
Jun 7, 2020
Merged

Ninja code #109

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
768f2ab
Update fork (#3)
Sjesc Oct 3, 2019
757bd6b
Traducir articulo ninja code
Sjesc Oct 3, 2019
d31b843
terminar traduccion del articulo
Sjesc Oct 4, 2019
2c30d17
Merge branch 'master' into ninja-code-2
joaquinelio Jun 3, 2020
55b0703
Update 1-js/03-code-quality/04-ninja-code/article.md
vplentinax Jun 6, 2020
8d66ef6
Update 1-js/03-code-quality/04-ninja-code/article.md
vplentinax Jun 6, 2020
0bfb298
Update 1-js/03-code-quality/04-ninja-code/article.md
vplentinax Jun 6, 2020
4b859ed
Update 1-js/03-code-quality/04-ninja-code/article.md
vplentinax Jun 6, 2020
6403c9c
Update 1-js/03-code-quality/04-ninja-code/article.md
vplentinax Jun 6, 2020
131d030
Update 1-js/03-code-quality/04-ninja-code/article.md
vplentinax Jun 6, 2020
82e2a7b
Update 1-js/03-code-quality/04-ninja-code/article.md
vplentinax Jun 6, 2020
4ab0735
Update 1-js/03-code-quality/04-ninja-code/article.md
vplentinax Jun 6, 2020
7e4afd4
Update 1-js/03-code-quality/04-ninja-code/article.md
vplentinax Jun 6, 2020
4a958df
Update 1-js/03-code-quality/04-ninja-code/article.md
vplentinax Jun 6, 2020
8293857
Update 1-js/03-code-quality/04-ninja-code/article.md
vplentinax Jun 6, 2020
6eea635
Update 1-js/03-code-quality/04-ninja-code/article.md
joaquinelio Jun 7, 2020
071d440
Apply suggestions from code review
joaquinelio Jun 7, 2020
d80ddf0
Update article.md
joaquinelio Jun 7, 2020
bef085b
Update article.md
joaquinelio Jun 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update 1-js/03-code-quality/04-ninja-code/article.md 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
  • Loading branch information
@vplentinax @EzequielCaste
vplentinax and EzequielCaste authored Jun 6, 2020
commit 4a958df128e0d26fcef031de986ae715bfa91466
1 change: 0 additions & 1 deletion 1-js/03-code-quality/04-ninja-code/article.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,6 @@ function render() {
Un programador que se adentra en `render` probablemente no notara que hay un `user` local opacando al de afuera.

Entonces intentaran trabajar con `user` asumiendo que es la variable externa, el resultado de `authenticateUser()`...
Comment thread
vplentinax marked this conversation as resolved.
Outdated
Then they'll try to work with `user` assuming that it's the external variable, the result of `authenticateUser()`... ¡Se activa la trampa! Hola, depurador...


## ¡Efectos secundarios en todas partes!
Expand Down