Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Writeroverload logs and swallowsIOException, allowing a partially written diff to look successful to the caller.Bridge the exception through the
Consumeroverload withUncheckedIOException, then rethrow the originalIOException. Regression tests fail during header, body and trailer output, including newline writes, and verify that writing stops immediately.Validation:
mvn -B -ntp clean packagepasses on JDK 8 and 17, including formatting, Checkstyle, both modules and Javadoc (156 tests, 3 skipped). All four new cases fail before the fix.