Skip to content

Simplify unit test display names #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FanJups wants to merge 23 commits into from
Closed

Simplify unit test display names #213

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
650d266
Starting to simplify unit test display names
FanJups Aug 21, 2023
5a653d8
Add copyright headers
FanJups Sep 2, 2023
d318133
Replace camel case only for methods not classes
FanJups Sep 2, 2023
217b28d
Consider numbers as words
FanJups Sep 2, 2023
4bd03d5
Comment about adding space before all numbers
FanJups Sep 2, 2023
601d45c
Add parameterized test
FanJups Sep 2, 2023
060e90d
Refactor parameterized test
FanJups Sep 2, 2023
2902f21
Add Javadoc and Refactor code
FanJups Sep 4, 2023
cc0ff85
Delete static modifier
FanJups Sep 4, 2023
6b52908
Undo changes in PageableTest
FanJups Sep 15, 2023
bf8cec3
Commenting custom annotation
FanJups Sep 15, 2023
7a23d38
Reset PageableTest to be the same as in main
FanJups Sep 15, 2023
2c67b41
Delete default constructor
FanJups Sep 15, 2023
3ddb87e
Make replaceCamelCaseAndUnderscoreAndNumber(String input) private and…
FanJups Sep 16, 2023
ed12e2a
Delete TODO comment
FanJups Sep 22, 2023
e205ac9
Create class under test
FanJups Sep 22, 2023
776389d
Check if method is annotated with Test or ParameterizedTest
FanJups Sep 22, 2023
5c0abc6
Test methods with parameters
FanJups Sep 23, 2023
331ad01
Update generator javadoc with parameterized test
FanJups Sep 23, 2023
fef312c
Rename method doNothing() to methodNotAnnotatedWithTestOrParameterize…
FanJups Oct 23, 2023
ee7436f
explicit testing
FanJups Oct 25, 2023
533d2ca
implicit testing
FanJups Oct 25, 2023
140bbf6
Uncommenting @DisplayNameGeneration
FanJups Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reset PageableTest to be the same as in main
  • Loading branch information
@FanJups
FanJups committed Oct 25, 2023
commit 7a23d382a838ca3fd004ef34edb252e1c7d6239f
6 changes: 3 additions & 3 deletions api/src/test/java/jakarta/data/page/PageableTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,11 @@ void shouldCreatePage() {
@DisplayName("Should be displayable as String with toString")
void shouldPageableDisplayAsString() {
assertSoftly(softly -> softly.assertThat(Pageable.ofSize(60).toString())
.isEqualTo("Pageable{page=1, size=60}"));
.isEqualTo("Pageable{page=1, size=60}"));

assertSoftly(softly -> softly.assertThat(Pageable.ofSize(80).sortBy(Sort.desc("yearBorn"), Sort.asc("monthBorn"),
Sort.asc("id")).toString())
.isEqualTo("Pageable{page=1, size=80, yearBorn DESC, monthBorn ASC, id ASC}"));
.isEqualTo("Pageable{page=1, size=80, yearBorn DESC, monthBorn ASC, id ASC}"));
}

@Test
Expand Down Expand Up @@ -202,4 +202,4 @@ void shouldReplaceSorts() {
softly.assertThat(p2.size()).isEqualTo(55);
});
}
}
}