[jaeger] Add extraVolumes and extraVolumeMounts to all-in-one deployment - #761
Merged
pavelnikolov merged 1 commit intoJun 14, 2026
Merged
Conversation
Signed-off-by: somaz <genius5711@gmail.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR adds configuration hooks to allow Jaeger users to inject additional Kubernetes volumes and volume mounts via Helm values, and bumps the chart patch version accordingly.
Changes:
- Add
jaeger.extraVolumes/jaeger.extraVolumeMountsvalues (with examples) to support custom storage/config mounts. - Render the new values into the Jaeger Deployment template under
spec.template.spec.volumesand the containervolumeMounts. - Bump chart version from
4.11.0to4.11.1.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| charts/jaeger/values.yaml | Introduces new values for extra volumes/mounts with commented examples. |
| charts/jaeger/templates/jaeger/jaeger-deploy.yaml | Wires the new values into the Deployment’s volumeMounts and volumes. |
| charts/jaeger/Chart.yaml | Patch version bump to reflect new chart functionality. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+247
to
+253
| extraVolumes: [] | ||
| # - name: badger-data | ||
| # persistentVolumeClaim: | ||
| # claimName: jaeger-badger-data | ||
| extraVolumeMounts: [] | ||
| # - name: badger-data | ||
| # mountPath: /badger |
Comment on lines
+121
to
+123
| {{- with .Values.jaeger.extraVolumeMounts }} | ||
| {{- toYaml . | nindent 12 }} | ||
| {{- end }} |
Comment on lines
+138
to
+140
| {{- with .Values.jaeger.extraVolumes }} | ||
| {{- toYaml . | nindent 8 }} | ||
| {{- end }} |
somaz94
added a commit
to somaz94/somaz94
that referenced
this pull request
Jun 11, 2026
pavelnikolov
approved these changes
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extraVolumesandextraVolumeMountsto the all-in-one Jaeger Deployment, restoring the ability to mount PVCs, secrets, and configmaps that the v4.2.0 rewrite removed (only the ConfigMap user-config/ui-config volumes remained).{{- with }}+toYamlpattern already used foraffinity/topologySpreadConstraintsin the same template.Fixes #737
Also resolves #735: a self-signed-CA secret for a TLS storage backend can now be mounted via a secret-type
extraVolumesentry plusextraVolumeMounts, restoring the v1extraSecretMountsuse case. If maintainers prefer re-adding the dedicatedextraSecretMountsconvenience shape (as used by the spark / es-maintenance jobs), happy to follow up.Test plan
helm lint charts/jaegerpasseshelm templatewith default values renders cleanly (no extra volume artifacts)helm templatewithextraVolumes/extraVolumeMountsset renders the PVC and secret mounts correctlycharts/jaeger/ci/*.yamlvalues files render cleanlyChart.yamlversion bumped 4.11.0 -> 4.11.1