Skip to content

[GH#59] Convert name/identifier(DD3) to description/name(DD4) #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olivhoenen merged 3 commits into from
Sep 29, 2025
Merged

[GH#59] Convert name/identifier(DD3) to description/name(DD4) #68

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14afe29
[GH#59] Convert name/identifier(DD3) to description/name(DD4)
Sep 10, 2025
842cde1
Merge branch 'develop' into renaming_3to4_name_identifier
dee-mew Sep 26, 2025
2d4f1de
resolved the lint error for code length limit
Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'develop' into renaming_3to4_name_identifier
  • Loading branch information
@dee-mew Deepak Mewar
dee-mew authored and Deepak Mewar committed Sep 29, 2025
commit 842cde16a12521c193e2173605883e01898efd80
19 changes: 19 additions & 0 deletions imas/test/test_ids_convert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,3 +573,22 @@ def test_4to3_name_identifier_mapping_magnetics():

# DD4 name -> DD3 identifier
assert dst.b_field_pol_probe[0].identifier == "TEST_NAME"


def test_3to4_cocos_hardcoded_paths():
# Check for existence in 3.42.0
factory = IDSFactory("3.42.0")
for ids_name, paths in _3to4_sign_flip_paths.items():
ids = factory.new(ids_name)
for path in paths:
# Check path exists and is not a FLT
metadata = ids.metadata[path]
assert metadata.data_type is IDSDataType.FLT

# Test a conversion
eq = factory.equilibrium()
eq.time_slice.resize(1)
eq.time_slice[0].boundary.psi = 3.141

eq4 = convert_ids(eq, "4.0.0")
assert eq4.time_slice[0].boundary.psi == -3.141
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.