Skip to content

added support of slicing for IDSStructArray #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prasad-sawantdesai wants to merge 57 commits into
base: develop
Choose a base branch
from
Open

added support of slicing for IDSStructArray #20

Changes from 1 commit
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
39d8a73
added support of slicing for IDSStructArray
prasad-sawantdesai Feb 27, 2025
6704375
removed pull_request event
prasad-sawantdesai Mar 17, 2025
3246c71
merged with develop
prasad-sawantdesai Nov 3, 2025
a043911
Merge branch 'develop' into feature/allow-slices-for-IDSStructArray
prasad-sawantdesai Nov 3, 2025
7119a18
added ids_slice.py and updated IDSStructArray to return IDSSlice obje…
prasad-sawantdesai Nov 6, 2025
78727b4
added ids_slice.py and updated IDSStructArray to return IDSSlice obje…
prasad-sawantdesai Nov 6, 2025
67f24c6
removed flake8 issue
prasad-sawantdesai Nov 6, 2025
f389f74
Merge branch 'develop' into feature/allow-slices-for-IDSStructArray
prasad-sawantdesai Nov 6, 2025
88e6310
Merge branch 'iterorganization:develop' into feature/allow-slices-for…
prasad-sawantdesai Nov 6, 2025
c1a5fba
updated documentation and examples of using IDSSlice
prasad-sawantdesai Nov 7, 2025
b5f55de
Merge branch 'feature/allow-slices-for-IDSStructArray' of github.com:…
prasad-sawantdesai Nov 7, 2025
a1091ed
fixed black formatting
prasad-sawantdesai Nov 12, 2025
f30d305
fix flake8 issue
prasad-sawantdesai Nov 12, 2025
674c25f
add array_slicing in the documentation
prasad-sawantdesai Nov 12, 2025
4cf5937
Fix per review comment https://github.com/iterorganization/IMAS-Pytho…
prasad-sawantdesai Nov 21, 2025
c57e64e
Fix as per review comment https://github.com/iterorganization/IMAS-Py…
prasad-sawantdesai Nov 21, 2025
c470bec
Fix as per review comment https://github.com/iterorganization/IMAS-Py…
prasad-sawantdesai Nov 21, 2025
156aded
Fix as per review comment https://github.com/iterorganization/IMAS-Py…
prasad-sawantdesai Nov 21, 2025
87158d2
Fix as per review comment https://github.com/iterorganization/IMAS-Py…
prasad-sawantdesai Nov 21, 2025
94e20f2
Fix as per review comment https://github.com/iterorganization/IMAS-Py…
prasad-sawantdesai Nov 21, 2025
8398537
Fix as per review comment https://github.com/iterorganization/IMAS-Py…
prasad-sawantdesai Nov 21, 2025
18d7fd0
Fix as per review comment https://github.com/iterorganization/IMAS-Py…
prasad-sawantdesai Nov 21, 2025
989513d
Fix as per review comment https://github.com/iterorganization/IMAS-Py…
prasad-sawantdesai Nov 21, 2025
3939e55
Fix as per review comment https://github.com/iterorganization/IMAS-Py…
prasad-sawantdesai Nov 21, 2025
2423a89
Fix as per review comment https://github.com/iterorganization/IMAS-Py…
prasad-sawantdesai Nov 21, 2025
69cb566
formatting with black and flake8
prasad-sawantdesai Nov 21, 2025
e1502f1
refactored code
prasad-sawantdesai Nov 21, 2025
224fbea
Merge branch 'develop' into feature/allow-slices-for-IDSStructArray
prasad-sawantdesai Nov 21, 2025
8099741
updated documentation
prasad-sawantdesai Nov 21, 2025
21ded45
Fix as per review comment https://github.com/iterorganization/IMAS-Py…
prasad-sawantdesai Nov 21, 2025
e94d634
fix issue in sphinx docs
prasad-sawantdesai Nov 21, 2025
e448883
lazy loaded objects supports slicing
prasad-sawantdesai Nov 21, 2025
32265d1
fix representation issue and empty slice raises exception https://git…
prasad-sawantdesai Nov 24, 2025
00752d2
fix first and second point fix __repr__ and Empty slices do not check…
prasad-sawantdesai Nov 28, 2025
93bdb50
fix first and second point fix __repr__ and Empty slices do not check…
prasad-sawantdesai Nov 28, 2025
757af75
added tests
prasad-sawantdesai Nov 28, 2025
d862073
fixed issues with to_array function
prasad-sawantdesai Nov 28, 2025
b2143f8
fixed documentation issue
prasad-sawantdesai Nov 28, 2025
0aa5a2c
fixed issue in sphinx doc generation
prasad-sawantdesai Nov 29, 2025
56f154e
raise value error when ragged arrays found https://github.com/iterorg…
prasad-sawantdesai Jan 5, 2026
b92883c
Removed Union and simplified __getitem__ method https://github.com/it…
prasad-sawantdesai Jan 5, 2026
0a4658d
Check if node is valid and return empty slice if array is empty https…
prasad-sawantdesai Jan 5, 2026
d91d25b
IDSSlice should have valid metadata, https://github.com/iterorganizat…
prasad-sawantdesai Jan 5, 2026
74e0d73
the size of all items is not the same as the first, there may be ragg…
prasad-sawantdesai Jan 5, 2026
16a608a
added property to get ids name in IDSMetadata class, build IDSSlice w…
prasad-sawantdesai Jan 5, 2026
9c56a3e
Properly unpack 0D data when reading an IDS from a netCDF file
maarten-ic Dec 17, 2025
7d8abaa
simplified values method according to suggestions from Maarten https:…
prasad-sawantdesai Jan 5, 2026
f085f82
Simplified __getitem__ method for lazy lading https://github.com/iter…
prasad-sawantdesai Jan 5, 2026
44a1110
simplified to_array method https://github.com/iterorganization/IMAS-P…
prasad-sawantdesai Jan 5, 2026
a3ca48c
fixed __getitem method principle of least astonishment, https://githu…
prasad-sawantdesai Jan 5, 2026
9116f19
fixed formatting
prasad-sawantdesai Jan 5, 2026
57034e4
Merge branch 'iterorganization:develop' into feature/allow-slices-for…
prasad-sawantdesai Jan 5, 2026
28a35f7
Cleanup unit tests: remove checks for imas-core (#92)
prasad-sawantdesai Jan 8, 2026
0de0782
Defer loading the default DD definitions (#95)
maarten-ic Jan 15, 2026
23bd921
Merge branch 'iterorganization:develop' into feature/allow-slices-for…
prasad-sawantdesai Jan 15, 2026
bb3972d
fix test cases
prasad-sawantdesai Jan 15, 2026
04a9eea
fix flake8 and black issues
prasad-sawantdesai Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix flake8 issue
  • Loading branch information
@prasad-sawantdesai
prasad-sawantdesai committed Nov 12, 2025
commit f30d305e6c98864aeb375d399fdc0acded2765c7
3 changes: 2 additions & 1 deletion imas/ids_struct_array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,8 @@ def __getitem__(self, item):
# Slicing is not supported on lazy-loaded arrays
Comment thread
prasad-sawantdesai marked this conversation as resolved.
Resolved
if self._lazy:
raise ValueError(
"Lazy-loaded IDSs do not support slicing. Use integer indexing instead."
"Lazy-loaded IDSs do not support slicing. "
"Use integer indexing instead."
)

# Handle slice by returning an IDSSlice
Expand Down
Loading