Repository navigation
WIP: Attempt to build on NERSC Perlmutter - #19
AreWeDreaming wants to merge 4 commits into
Conversation
| set(jsonfortran_FOUND TRUE) | ||
| else() | ||
| message(WARNING "JSON Library libjsonfortran.a NOT found at " ${LibJSON}) | ||
| message(WARNING "JSON Library ljsonfortran NOT found at " ${LibJSON}) |
There was a problem hiding this comment.
Why did you change the name here?
There was a problem hiding this comment.
Because I am linking against ljsonfortran.so (potentially)
There was a problem hiding this comment.
I understand the drop of the extension. But you were only looking for the existence of libjsonfortran.a or libjsonfortran.so, not ljsonfortran.
| @@ -78,7 +97,7 @@ if(LibJSON) | |||
| set(LibJSON "${LibJSON}/libjsonfortran.a") | |||
There was a problem hiding this comment.
We should probably split this up so that an existing shared object then leads to forcing the linking against the statically linked library, which conda does not provide.
| else | ||
| ifndef SOLPS_CPP | ||
| DEFINES += -DNO_JSON | ||
| endif |
There was a problem hiding this comment.
This ifndef SOLPS_CPP basically means "if we are compiling a standa-lone Eirene instance outside the SOLPS environment". There is no reason why it could not also use JSON.
| GLI_HOME ?= /global/project/projectdirs/atom/atom-install-cori/solps-libs/lib_gfortran | ||
| SOLPSLIB ?= ${SOLPSTOP}/lib/${HOST_NAME}.${COMPILER} | ||
| GR_ROOT ?= ${SOLPSLIB}/gr | ||
| GLI_HOME ?= ${SOLPSLIB}/gli/src/gks |
There was a problem hiding this comment.
Just as per the comment below. SOLPSLIB will only exist if one is compiling inside a SOLPS environment. But GR and GLI are separate module that come form outside SOLPS-ITER, so they have their own workspace and that is where one should expect to find the libraries.
| LD_GR ?= -L${GR_ROOT} -lgr | ||
| LD_GKS ?= -L${GLI_HOME} -lgks | ||
| LD_NAG ?= -L${SOLPSLIB} -lblas -llapack | ||
| LD_GKS ?= -L${SOLPSLIB}/gli/src/gks -lgks |
| @@ -78,7 +97,7 @@ if(LibJSON) | |||
| set(LibJSON "${LibJSON}/libjsonfortran.a") | |||
| set(jsonfortran_FOUND TRUE) | ||
| else() | ||
| message(WARNING "JSON Library libjsonfortran.a NOT found at " ${LibJSON}) | ||
| message(WARNING "JSON Library ljsonfortran NOT found at " ${LibJSON}) |
There was a problem hiding this comment.
I understand the drop of the extension. But you were only looking for the existence of libjsonfortran.a or libjsonfortran.so, not ljsonfortran.
3 participants
Minor modification to use pkg-config to discover Conda provided json-fortran,