A branch that puts this package close to parity with an blank template - #13
anthonyjclark wants to merge 13 commits into
Conversation
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| @@ -0,0 +1 @@ | |||
| """No task registrations at this milestone.""" | |||
There was a problem hiding this comment.
This entry-point module now registers no IsaacTutorial-* environments, and the new registration test confirms that this is intentional. However, the README still provides smoke-test, training, benchmark, play, and evaluation commands for those task IDs. Users following those instructions will request unavailable Gymnasium tasks. Please update the README for this scaffold milestone or restore the registrations.
| uv run isaaclab play --rl_library rsl_rl --task IsaacTutorial-Place-Vial-SO101 \ | ||
| --num_envs 1024 --checkpoint latest --deterministic \ | ||
| --external_callback isaaclab_tutorial.utils.evaluation.install_episode_counter \ | ||
| --external_callback so101_place_vial.utils.evaluation.install_episode_counter \ |
There was a problem hiding this comment.
The updated command points to so101_place_vial.utils.evaluation.install_episode_counter, but this PR deletes the previous evaluation module without adding so101_place_vial/utils/evaluation.py. If this command is reached after task registration is restored, the callback cannot be imported and evaluation will stop before rollout. Remove this instruction for the blank milestone or restore the utility at the documented path.
| [project.entry-points."isaaclab.tasks"] | ||
| so101-vial-place = "isaaclab_tutorial.tasks" | ||
|
|
||
| [project.scripts] | ||
| generate-so101-resets = "isaaclab_tutorial.tasks.place_vial.reset.generator:generate_main" | ||
| view-so101-resets = "isaaclab_tutorial.tasks.place_vial.reset.generator:view_main" | ||
| so101-vial-place = "so101_place_vial.tasks" |
There was a problem hiding this comment.
The manifest removes the generate-so101-resets and view-so101-resets project scripts, while the README still tells users to run both commands and says the deleted reset dataset is checked in and ready for training. A fresh checkout therefore cannot perform the documented reset maintenance or provide the claimed dataset. Please revise that section for the scaffold or retain the scripts and asset.
|
Want your agent to iterate on Greptile's feedback? Try greploops. |
1 participant
No description provided.