Skip to content

Learning path 5: remove all distillation functionality - #12

Open
anthonyjclark wants to merge 10 commits into
isaac-sim:5-teacher-policyfrom
anthonyjclark:5-teacher-policy
Open

anthonyjclark wants to merge 10 commits into
isaac-sim:5-teacher-policyfrom
anthonyjclark:5-teacher-policy

Conversation

@anthonyjclark

Copy link
Copy Markdown

This branch removes all distillation/student/wrist-camera functionality.

@greptile-apps

greptile-apps Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

[Medium risk] Removes distillation training paths and camera-based task variants.

The PR does not appear ready to merge because the README still directs users to removed camera tasks.

Findings

  1. P1 Removed Tasks Still Documented ▶

Summary

The PR removes the camera and distillation task registrations, configurations, and tests, leaving the state-policy task. The latest changes add MoviePy as a dependency.

  • No new actionable issue was established in the changes since the previous review.

Reviews (6) · Last reviewed commit: "Declare compatible MoviePy recording dep..."

Comment thread README.md Outdated

```text
src/isaaclab_tutorial/
src/so101_place_vial/

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Removed Tasks Still Documented

The camera and distillation registrations and configuration modules were removed, but the README still provides training and evaluation commands for IsaacTutorial-Place-Vial-SO101-Camera and IsaacTutorial-Place-Vial-SO101-Camera-Distillation. It also lists the deleted camera configuration in the package layout. Users following these workflows will target tasks that are no longer registered, so the obsolete camera sections, results, and layout entries should be removed.

@greptile-apps

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant