Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
OS-jacobbell
approved these changes
Oct 2, 2026
| import { ionPageVisible, withTestingMode } from './utils/test-utils'; | ||
|
|
||
| test.describe('Outlet Unmount Before Ready', () => { | ||
| test('does not throw when an ionPage outlet unmounts before it is ready', async ({ page }, testInfo) => { |
Contributor
There was a problem hiding this comment.
These usually say "should," right?
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31513
What is the current behavior?
Currently, an
IonRouterOutletwithionPagethat unmounts before itscomponentOnReadycallback fires throwsCannot read properties of null (reading 'classList'), because React has already cleared the ref the callback reads inOutletPageManager.What is the new behavior?
We now capture the outlet element when the callback is scheduled and skip the callback if the ref no longer points to it, so an unmounted outlet doesn't touch its classes or register with the parent stack.
Does this introduce a breaking change?
Other information
The new test page mounts an outlet and removes it in a layout effect, which reproduces the error on every tap on
main.Current dev build