Repository navigation
fix: accept string audiences in ID tokens - #58
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validate_id_tokenrejects valid ID tokens with a string-valued audience because it compares the first character ofaudwith the client ID. OpenID Connect allows a single audience to be represented as a string (section 2).Normalize a string audience to a one-element list before the existing comparison. Signature verification, issuer/expiry checks, and existing array handling remain in place.
The new tests use real RS256 signatures and cover matching string/list audiences, mismatched audiences, a string with a matching prefix, and an invalid signature. The matching-string case fails before the fix. All 30 tests pass afterward, including the existing discovery tests;
git diff --checkpasses.