Skip to content

Repository navigation

Fix SyntaxError on articles with hyphenated locales #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anubhav-intercom merged 4 commits into from
Oct 7, 2026
Merged

Fix SyntaxError on articles with hyphenated locales #626

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5baa674
Define dynamic accessors without evaluating source strings
anubhav-intercom Oct 6, 2026
2f938e8
Keep original attribute keys in serialised output
anubhav-intercom Oct 6, 2026
d87985b
Upgrade CircleCI config to version 2.1
anubhav-intercom Oct 7, 2026
38f5135
Keep CI check names while using 2.1-compatible job keys
anubhav-intercom Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Upgrade CircleCI config to version 2.1 
CircleCI no longer accepts version 2 configs, so pipelines on this
repo error before any job runs and the required test checks never
report.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
  • Loading branch information
@anubhav-intercom @claude
anubhav-intercom and claude committed Oct 7, 2026
commit d87985b9099d40f3d1f9a8560b7f5d44803bd2dc
3 changes: 1 addition & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version: 2
version: 2.1
jobs:
"Test against Ruby 2.4":
docker:
Expand Down Expand Up @@ -75,7 +75,6 @@ jobs:
- run: bundle exec rake

workflows:
version: 2
build_and_test:
jobs:
- "Test against Ruby 2.4":
Expand Down
Loading