Skip to content

feat!: Stream incremental changes directly to the collection view #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbmorley merged 22 commits into from
Jul 30, 2026
Merged

feat!: Stream incremental changes directly to the collection view #30

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
edce4c8
feat: Stream incremental changes directly to the collection view
jbmorley Jan 27, 2026
787ee20
Remove unnecessary comment
jbmorley Jan 27, 2026
5b84a24
Make it possible to toggle streaming mode
jbmorley Jan 27, 2026
0c53839
Send update when the proxy connects
jbmorley Jan 27, 2026
3c88770
Rename `updateItems` to `setItems`
jbmorley Jan 27, 2026
3266b2d
Update the copyright and simplify the comments
jbmorley Jan 27, 2026
901aa35
Update copyright again
jbmorley Jan 27, 2026
b0faef8
Support removing items
jbmorley Jan 27, 2026
ec036cb
Remove logging
jbmorley Jan 27, 2026
ec35e20
Support moving items
jbmorley Jan 28, 2026
5faf2d8
Submenu and fix cell updates
jbmorley Jan 28, 2026
813cce2
Add comments
jbmorley Jan 28, 2026
83c4c29
Address compiler warnings
jbmorley Jan 28, 2026
1b1534a
Start using identifiers internally
jbmorley Jan 28, 2026
01dbdea
Remove the `Hashable` constraint on `Element`
jbmorley Jan 28, 2026
6f78677
Test update behavior (and fix update bugs)
jbmorley Jan 28, 2026
f36d6f6
Small tidy up
jbmorley Jan 28, 2026
971c814
Small documentation improvement.
jbmorley Jan 28, 2026
cd1034a
Remove more `Hashable` constraints
jbmorley Jan 28, 2026
6039c63
Remove todo
jbmorley Jan 28, 2026
1202b7c
Guard against no-op moves
jbmorley Jan 28, 2026
83f7b31
Remove lingering todo
jbmorley Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Guard against no-op moves
  • Loading branch information
@jbmorley
jbmorley committed Jan 28, 2026
commit 1202b7c3401d3aad98f4046f39bdf44c6967a756
2 changes: 1 addition & 1 deletion Sources/SelectableCollectionView/Views/CollectionViewContainer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ public class CollectionViewContainer<Element: Identifiable, Content: View, Deleg
guard let fromIndex = snapshot.indexOfItem(item.id) else {
fatalError("Attempted to move item not in list.")
}
if fromIndex == index || fromIndex + 1 == index { // TODO: Make this a guard.
guard fromIndex != index && fromIndex + 1 != index else {
return
}
guard fromIndex < snapshot.itemIdentifiers.count else {
Expand Down